Skip to content

Conversation

@jkotas
Copy link
Member

@jkotas jkotas commented Jun 16, 2023

Fixes #75807

@ghost ghost assigned jkotas Jun 16, 2023
@ghost
Copy link

ghost commented Jun 16, 2023

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #75807

Author: jkotas
Assignees: -
Labels:

area-NativeAOT-coreclr

Milestone: -

@jkotas
Copy link
Member Author

jkotas commented Jun 16, 2023

This is the only remaining redundant lookup that is reasonable to fix. The two remaining ones are:

  • IsUnwindable: debug-only, not perf critical
  • GetReturnAddressHijackInfo: it is hard to pass the resolved methodinfo through number of layers

@jkotas jkotas marked this pull request as ready for review June 16, 2023 04:12
@jkotas jkotas requested a review from MichalStrehovsky as a code owner June 16, 2023 04:12
@jkotas
Copy link
Member Author

jkotas commented Jun 16, 2023

/azp run runtime-extra-platforms

@jkotas jkotas requested review from VSadov and filipnavara June 16, 2023 04:13
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@VSadov
Copy link
Member

VSadov commented Jun 16, 2023

This is arm64-specific, right? (just to confirm I read it correctly)

Copy link
Member

@VSadov VSadov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!!

@jkotas
Copy link
Member Author

jkotas commented Jun 16, 2023

This is arm64-specific, right? (just to confirm I read it correctly)

Yes, this is Arm64 specific.

@jkotas jkotas merged commit 36439c5 into dotnet:main Jun 16, 2023
@jkotas jkotas deleted the methodinfo branch June 16, 2023 08:18
@ghost ghost locked as resolved and limited conversation to collaborators Jul 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[NativeAOT] Unnecessary lookup in TrailingEpilogueInstructionsCount

3 participants