SPMI: HTML escape lines inside diffs #87861
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The summarize script will convert markdown diff code blocks into manually colored HTML tags because AzDO does not support proper highlighting in its preview. However, when we do this we should also take care to escape the contents as otherwise it can start being interpreted as HTML tags. For example, in a recent case a field named "<Option>k__BackingField" caused the preview to be truncated because <option> was interpreted as a HTML tag.
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsThe summarize script will convert markdown diff code blocks into manually colored HTML tags because AzDO does not support proper highlighting in its preview. However, when we do this we should also take care to escape the contents as otherwise it can start being interpreted as HTML tags. For example, in a recent case a field named "k__BackingField" caused the preview to be truncated because was interpreted as a HTML tag.
|
Member
Author
Member
Author
|
cc @dotnet/jit-contrib PTAL @EgorBo |
markples
approved these changes
Jun 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The summarize script will convert markdown diff code blocks into manually colored HTML tags because AzDO does not support proper highlighting in its preview. However, when we do this we should also take care to escape the contents as otherwise it can start being interpreted as HTML tags. For example, in a recent case a field named
<Option>k__BackingFieldcaused the preview to be truncated because was interpreted as a HTML tag.