Update binding generator to do case-insensitive config-key/property name matching, & make some formatting improvements #88338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
layomia
commented
Jul 3, 2023
layomia
commented
- Fixes ConfigurationBinder Source Generator is comparing configuration keys case-sensitively #88112
- Contributes to Avoid emitting code that honors BinderOptions when not specified in binding call #88110
- Unblocks PRs Remove handwritten binding logic from Logging.Console; use generator instead #88067 & Enable configuration binding generator in TodosApi app aspnet/Benchmarks#1874
layomia
added
area-Extensions-Configuration
source-generator
|
Tagging subscribers to this area: @dotnet/area-extensions-configuration Issue Details
|
…ame matching, & make some formatting improvements
This was referenced Jul 3, 2023
eerhardt
reviewed
Jul 5, 2023
...ourceGenerationTests/Microsoft.Extensions.Configuration.Binder.SourceGeneration.Tests.csproj
Outdated
Show resolved
Hide resolved
...ensions.Configuration.Binder/tests/SourceGenerationTests/Baselines/Collections.generated.txt
Outdated
Show resolved
Hide resolved
...tensions.Configuration.Binder/tests/SourceGenerationTests/Baselines/Primitives.generated.txt
Outdated
Show resolved
Hide resolved
...ensions.Configuration.Binder/tests/SourceGenerationTests/Baselines/Collections.generated.txt
Outdated
Show resolved
Hide resolved
...ensions.Configuration.Binder/tests/SourceGenerationTests/Baselines/Collections.generated.txt
Outdated
Show resolved
Hide resolved
...ensions.Configuration.Binder/tests/SourceGenerationTests/Baselines/Collections.generated.txt
Outdated
Show resolved
Hide resolved
...ensions.Configuration.Binder/tests/SourceGenerationTests/Baselines/Collections.generated.txt
Outdated
Show resolved
Hide resolved
...ensions.Configuration.Binder/tests/SourceGenerationTests/Baselines/Collections.generated.txt
Outdated
Show resolved
Hide resolved
...ensions.Configuration.Binder/tests/SourceGenerationTests/Baselines/Collections.generated.txt
Show resolved
Hide resolved
eerhardt
reviewed
Jul 11, 2023
...aries/Microsoft.Extensions.Configuration.Binder/gen/ConfigurationBindingGenerator.Emitter.cs
Outdated
Show resolved
Hide resolved
layomia
force-pushed
the
binder-gen-fixes
branch
3 times, most recently
from
f9e16d6 to
dee11a0
Compare
layomia
force-pushed
the
binder-gen-fixes
branch
from
dee11a0 to
b65b0a4
Compare
eerhardt
approved these changes
Jul 11, 2023
Member
eerhardt
left a comment
eerhardt
left a comment
There was a problem hiding this comment.
It might be good to get a review from @tarekgh and/or @eiriktsarpalis as well.
...ion.Binder/tests/SourceGenerationTests/Baselines/ServiceCollection/Configure_T.generated.txt
Show resolved
Hide resolved
tarekgh
reviewed
Jul 11, 2023
| } | ||
| } | ||
|
|
||
| public static void BindCore(IConfiguration configuration, ref List<int> obj, BinderOptions? binderOptions) |
Member
Contributor
Author
There was a problem hiding this comment.
Similar question here #88338 (comment); I need to take a deeper look outside this PR.
tarekgh
reviewed
Jul 11, 2023
...inder/tests/SourceGenerationTests/Baselines/ServiceCollection/Configure_T_name.generated.txt
Show resolved
Hide resolved
tarekgh
approved these changes
Jul 11, 2023
Member
tarekgh
left a comment
tarekgh
left a comment
There was a problem hiding this comment.
LGTM. added a couple of questions.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.