Disallow Options source gen produce diagnostics from outside the compilation #88396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-extensions-options Issue DetailsFixes #88152
|
Member
Author
tarekgh
added
the
source-generator
xakep139
reviewed
Jul 5, 2023
Member
Author
|
@xakep139 I have modified the fix to let the diagnostics use the closest location of the failure inside the compilation. I tested it with Visual Studio too :-) please have a look. Thanks! |
xakep139
reviewed
Jul 7, 2023
src/libraries/Microsoft.Extensions.Options/tests/SourceGeneration.Unit.Tests/Main.cs
Outdated
Show resolved
Hide resolved
xakep139
reviewed
Jul 7, 2023
src/libraries/Microsoft.Extensions.Options/tests/SourceGeneration.Unit.Tests/Main.cs
Outdated
Show resolved
Hide resolved
xakep139
reviewed
Jul 7, 2023
src/libraries/Microsoft.Extensions.Options/tests/SourceGeneration.Unit.Tests/Main.cs
Outdated
Show resolved
Hide resolved
xakep139
approved these changes
Jul 7, 2023
Contributor
xakep139
left a comment
xakep139
left a comment
There was a problem hiding this comment.
Added a few nit comments, but the PR LGTM
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #88152