Fix Vector512 rightshift

[MichalPetryka]

Fixes #89338

[ghost]

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Fixes #89338

Author:	MichalPetryka
Assignees:	-
Labels:	area-CodeGen-coreclr
Milestone:	-

[danmoseley]

Do we need a test?

[BruceForstall]

@tannergooding @dotnet/avx512-contrib PTAL

[tannergooding]

Change is correct, but adding tests would still be desirable.

Looks like the operator shift tests are missing entirely, which would explain why this wasn't caught earlier.

You'd need to add the relevant entries to https://github.com/dotnet/runtime/blob/main/src/tests/Common/GenerateHWIntrinsicTests/GenerateHWIntrinsicTests_General.cs and likely clone the existing BinOp template to have a BinOpImm variant (much as exists for the method cases)

[tannergooding]

@MichalPetryka, will you be able to add the necessary tests for this or do you need someone to pick it up?

[MichalPetryka]

@MichalPetryka, will you be able to add the necessary tests for this or do you need someone to pick it up?

I've tried looking into creating a new template for the tests but I had a bit of trouble understanding what's the proper way to change that, I'd like somebody else to take care of this.

[tannergooding]

CC. @fanyang-mono, seems there's a bug in the Mono shift logic where it isn't masking the shiftAmount.

It needs to be amount & ((sizeof(T) * 8) - 1):

• byte/sbyte: x & 7
• short/ushort: x & 15
• int/uint/float: x & 31
• long/ulong/double: x & 63

[tannergooding]

Logged #89868 for the other bug that's being worked around.

[fanyang-mono]

Please disable the failing tests on Build osx-x64 Release AllSubsets_Mono_Interpreter_RuntimeTests monointerpreter and open an issue for it and assign it to me. I will look into it later.

[JulieLeeMSFT]

It is just a few days away from RC1 snap. What is the status of this PR? @MichalPetryka, @tannergooding.

[tannergooding]

@JulieLeeMSFT, should be ready for merge now that tests were added and the Arm64 issue was resolved in #90051

It needs sign-off from @dotnet/jit-contrib