Skip to content

Conversation

@radekdoulik
Copy link
Member

@radekdoulik radekdoulik commented Jul 25, 2023

This is the first part of changes to make wasm/SIMD optional again, #89302

The WASM_OPT_ADDITIONAL_FLAGS is not used anymore, so remove it.

Force relink when disabling SIMD or EH.

This is the first part of changes to make wasm/SIMD optional again,
dotnet#89302
@radekdoulik radekdoulik requested review from kg, pavelsavara and radical and removed request for kg July 25, 2023 12:21
@ghost ghost added the area-Build-mono label Jul 25, 2023
@ghost ghost assigned radekdoulik Jul 25, 2023
@radekdoulik
Copy link
Member Author

counts of the SIMD instructions in the bench sample (aot) to check the changes. the remaining instructions come from mono runtime libs and will be handled in separate PR

> wa-info -d src/mono/sample/wasm/browser-bench/bin-head-nosimd/Release/AppBundle/_framework/dotnet.native.wasm|grep SIMD|wc -l
    6025
> wa-info -d src/mono/sample/wasm/browser-bench/bin-head-simd/Release/AppBundle/_framework/dotnet.native.wasm|grep SIMD|wc -l 
   13060
> wa-info -d src/mono/sample/wasm/browser-bench/bin-PR-nosimd/Release/AppBundle/_framework/dotnet.native.wasm|grep SIMD|wc -l 
    1408
> wa-info -d src/mono/sample/wasm/browser-bench/bin-PR-simd/Release/AppBundle/_framework/dotnet.native.wasm|grep SIMD|wc -l 
   13060

@pavelsavara
Copy link
Member

Please also make it to trigger WasmBuildNative similar to

<WasmBuildNative Condition="'$(WasmBuildNative)' == '' and '$(WasmEnableLegacyJsInterop)' == 'false'" >true</WasmBuildNative>

Also please do it for WasmEnableExceptionHandling

@radekdoulik radekdoulik merged commit 5be8320 into dotnet:main Jul 26, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Aug 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants