[wasm] Do not build mono libs with -msimd128
#89502
Conversation
Make it optional, build only minimal set of code witch required `-msimd128` to separate library. Also provide "stub" nosimd version of this library. Choose the appropriate library during linking.
radekdoulik
requested review from
BrzVlad,
SamMonoRT,
kotlarmilos,
lambdageek,
lewing,
marek-safar,
pavelsavara,
radical and
vargaz
as code owners
|
could we have WBT for this ? |
yeah, I plan to add tests later in another PR, with wa-info involved. |
kg
left a comment
kg
left a comment
There was a problem hiding this comment.
I'm not 100% confident in this, but it looks mergeable to me. One big caveat:
The result of this is that the EnableSIMD != 'true' scenario will be much slower than it was before I added interp PackedSimd support. Before, we had support for all the non-packedsimd SIMD APIs in the interpreter, even if the actual implementations were not using native WebAssembly SIMD. Those APIs resulted in sizable performance improvements. Because you're now disabling all SIMD instead of just PackedSimd, users with EnableSIMD set to false will probably experience performance worse than net7.
AFAIK the only part of the interpreter that actually relies on msimd128 is PackedSimd.
|
/backport to release/8.0-rc1 |
|
Started backporting to release/8.0-rc1: https://github.com/dotnet/runtime/actions/runs/5892974848 |
|
We should add a test to build, and run an app with simd turned off. |
ghost
locked as resolved and limited conversation to collaborators
5 participants
Make it optional, move minimal set of code, which requires
-msimd128, to separate library. Also provide "stub" nosimd version of that library.Choose the appropriate library during app linking.
Part of solution for #89302