[mono] Fix second pass of MarshallingPInvokeScanner with metadata-free DLLs #89555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vargaz
approved these changes
Jul 27, 2023
kotlarmilos
approved these changes
Jul 27, 2023
|
|
||
| using FileStream file = new FileStream(assyPath, FileMode.Open, FileAccess.Read, FileShare.ReadWrite); | ||
| using PEReader peReader = new PEReader(file); | ||
| if (!peReader.HasMetadata) |
Member
There was a problem hiding this comment.
Nit: May be good to encapsulate this, so we don't forget to check peReader.HasMetadata each time it is created, but I think it is nice to have.
Member
|
/azp run runtime-ioslike |
|
No commit pushedDate could be found for PR 89555 in repo dotnet/runtime |
Member
|
/azp run runtime-ioslike |
|
No commit pushedDate could be found for PR 89555 in repo dotnet/runtime |
Member
|
/azp run runtime-ioslike |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
The failure looks related. The scanner invokes GetAssemblyName which ends up with: |
Member
|
/azp run runtime-ioslike |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
The failures shouldn't be related. Thanks! |
This was referenced Jul 27, 2023
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the second pass of #89429 when trying to read DLLs that have no metadata. The first pass was addressed in #89430.