Skip to content

Conversation

@rzikm
Copy link
Member

@rzikm rzikm commented Aug 1, 2023

Fixes #89779. The change to use www.github.com was done after discussion with @wfurt.

Grepping the source code shows that we are using https://microsoft.com on other places as well, but so far they did not turn up in a CI report as failures, so I would prefer to do them as we encounter them.

@ghost ghost assigned rzikm Aug 1, 2023
@ghost
Copy link

ghost commented Aug 1, 2023

Tagging subscribers to this area: @dotnet/ncl, @bartonjs, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #89779. The change to use www.github.com was done after discussion with @wfurt.

Grepping the source code shows that we are using https://microsoft.com on other places as well, but so far they did not turn up in a CI report as failures, so I would prefer to do them as we encounter them.

Author: rzikm
Assignees: -
Labels:

area-System.Net.Security

Milestone: -

@rzikm
Copy link
Member Author

rzikm commented Aug 1, 2023

/azp run runtime-libraries-coreclr-outerloop

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@rzikm
Copy link
Member Author

rzikm commented Aug 1, 2023

/azp list

@azure-pipelines
Copy link

CI/CD Pipelines for this repository:

@rzikm
Copy link
Member Author

rzikm commented Aug 1, 2023

/azp run runtime-libraries-coreclr outerloop

Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rzikm
Copy link
Member Author

rzikm commented Aug 2, 2023

The test in question is passing on CI. Other failures are unrelated.

@rzikm rzikm merged commit b7a1b42 into dotnet:main Aug 2, 2023
@karelz karelz added this to the 8.0.0 milestone Aug 3, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Sep 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Test Failure] System.Net.Security.Tests.CertificateValidationRemoteServer.DefaultConnect_EndToEnd_Ok(host: "www.microsoft.com")

3 participants