Skip to content

Apply mitigations for a recent STJ performance regression #89856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
eiriktsarpalis merged 1 commit into from
Aug 2, 2023
Merged

Apply mitigations for a recent STJ performance regression #89856

eiriktsarpalis merged 1 commit into from
Aug 2, 2023

Conversation

@eiriktsarpalis
Copy link
Member

@eiriktsarpalis eiriktsarpalis commented Aug 2, 2023

Fix #89794. Mitigates a necessary performance regression introduced by #89418.

Method Branch Mean Error StdDev Median Min Max Ratio MannWhitney(3%) RatioSD Gen0 Allocated Alloc Ratio
NewCustomConverter main 28.87 us 9.279 us 9.529 us 23.93 us 23.44 us 54.01 us 1.00 Base 0.00 0.2841 9.11 KB 1.00
NewCustomConverter PR 19.51 us 1.547 us 1.519 us 18.96 us 18.18 us 24.38 us 0.71 Faster 0.15 0.2490 7.87 KB 0.86

@ghost ghost added the area-System.Text.Json label Aug 2, 2023
@ghost ghost assigned eiriktsarpalis Aug 2, 2023
@eiriktsarpalis eiriktsarpalis requested a review from tarekgh August 2, 2023 15:04
@eiriktsarpalis eiriktsarpalis added this to the 8.0.0 milestone Aug 2, 2023
@ghost
Copy link

ghost commented Aug 2, 2023

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix #89794. Mitigates a necessary performance regression introduced by #89418.

Method Branch Mean Error StdDev Median Min Max Ratio MannWhitney(3%) RatioSD Gen0 Allocated Alloc Ratio
NewCustomConverter main 28.87 us 9.279 us 9.529 us 23.93 us 23.44 us 54.01 us 1.00 Base 0.00 0.2841 9.11 KB 1.00
NewCustomConverter PR 19.51 us 1.547 us 1.519 us 18.96 us 18.18 us 24.38 us 0.71 Faster 0.15 0.2490 7.87 KB 0.86
Author: eiriktsarpalis
Assignees: -
Labels:

area-System.Text.Json
Milestone: -

@eiriktsarpalis eiriktsarpalis requested a review from layomia August 2, 2023 15:04
@eiriktsarpalis eiriktsarpalis added the tenet-performance Performance related issue label Aug 2, 2023
tarekgh
tarekgh approved these changes Aug 2, 2023
View reviewed changes
Copy link
Member

@tarekgh tarekgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added question. LGTM otherwise.

@eiriktsarpalis eiriktsarpalis merged commit 4ceb853 into dotnet:main Aug 2, 2023
@eiriktsarpalis eiriktsarpalis deleted the fix/attribute-perf-regression branch August 2, 2023 18:11
@cincuranet
Copy link
Contributor

cincuranet commented Aug 8, 2023

Improvements:

@ghost ghost locked as resolved and limited conversation to collaborators Sep 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tarekgh tarekgh tarekgh approved these changes

@stephentoub stephentoub Awaiting requested review from stephentoub

@layomia layomia Awaiting requested review from layomia

Assignees

@eiriktsarpalis eiriktsarpalis

Labels

area-System.Text.Json tenet-performance Performance related issue

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

System.Text.Json.Serialization.Tests.ColdStartSerialization<SimpleStructWithProperties>

3 participants

@eiriktsarpalis @cincuranet @tarekgh