Skip to content

Fix up InlineArray tests #90192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AaronRobinsonMSFT merged 4 commits into from
Aug 9, 2023
Merged

Fix up InlineArray tests #90192

AaronRobinsonMSFT merged 4 commits into from
Aug 9, 2023

Conversation

@AaronRobinsonMSFT
Copy link
Member

@AaronRobinsonMSFT AaronRobinsonMSFT commented Aug 8, 2023

Fixes #88957
Fixes #88861

/cc @VSadov @mangod9

@AaronRobinsonMSFT AaronRobinsonMSFT added this to the 8.0.0 milestone Aug 8, 2023
mangod9
mangod9 approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@mangod9 mangod9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing these!

@VSadov
Copy link
Member

VSadov commented Aug 8, 2023

Thanks! I really appreciate help with these.
Just let me know next time when poaching assigned bugs. I was about to start on these and we could have overlapped.

That said, getting these out of the way is completely welcome!

VSadov
VSadov approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@VSadov VSadov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

lambdageek
lambdageek reviewed Aug 9, 2023
View reviewed changes
lambdageek
lambdageek reviewed Aug 9, 2023
View reviewed changes
@build-analysis build-analysis bot mentioned this pull request Aug 9, 2023
Closed
@VSadov VSadov mentioned this pull request Aug 9, 2023
Closed
@AaronRobinsonMSFT
Copy link
Member Author

AaronRobinsonMSFT commented Aug 9, 2023

This is a container timeout and unrelated.

@AaronRobinsonMSFT AaronRobinsonMSFT merged commit f8a1a6c into dotnet:main Aug 9, 2023
@AaronRobinsonMSFT AaronRobinsonMSFT deleted the inlinearray_tests branch August 9, 2023 23:15
@matouskozak matouskozak mentioned this pull request Aug 11, 2023
Closed
@stefanschnabs stefanschnabs mentioned this pull request Aug 19, 2023
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Sep 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lambdageek lambdageek lambdageek left review comments

@VSadov VSadov VSadov approved these changes

@mangod9 mangod9 mangod9 approved these changes

Assignees

@AaronRobinsonMSFT AaronRobinsonMSFT

Labels

area-TypeSystem-coreclr

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

Loader/classloader/InlineArray/InlineArrayValid.cs need to be updated to work with latest roslyn InlineArrayInvalid needs to be converted to il

4 participants

@AaronRobinsonMSFT @VSadov @lambdageek @mangod9