Skip to content

Reenable properties disabled in illink.targets #90231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
akoeplinger wants to merge 1 commit into from
Closed

Reenable properties disabled in illink.targets #90231

akoeplinger wants to merge 1 commit into from

Conversation

@akoeplinger
Copy link
Member

@akoeplinger akoeplinger commented Aug 9, 2023

We're now using a preview6 SDK.

@akoeplinger
Reenable properties disabled in illink.targets
9f0ed94 
We're now using a preview6 SDK
@akoeplinger akoeplinger requested a review from ViktorHofer August 9, 2023 14:07
@ghost ghost added the linkable-framework Issues associated with delivering a linker friendly framework label Aug 9, 2023
@ghost ghost assigned akoeplinger Aug 9, 2023
@ghost
Copy link

ghost commented Aug 9, 2023

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

We're now using a preview6 SDK.

Author: akoeplinger
Assignees: -
Labels:

area-Infrastructure-libraries
Milestone: -

@akoeplinger akoeplinger marked this pull request as draft August 9, 2023 14:16
@akoeplinger
Copy link
Member Author

akoeplinger commented Aug 9, 2023

Looks like this still fails:

.dotnet/sdk/8.0.100-preview.6.23330.14/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(90,5): error NETSDK1195: (NETCORE_ENGINEERING_TELEMETRY=Restore) Trimming, or code compatibility analysis for trimming, single-file deployment, or ahead-of-time compilation is not supported for the target framework. For more information, see https://aka.ms/netsdk1195

/cc @sbomer

@ViktorHofer ViktorHofer requested a review from sbomer August 9, 2023 16:14
sbomer
sbomer reviewed Aug 9, 2023
View reviewed changes
eng/illink.targets
<!-- Don't use SDK's trimming functionality.
TODO: Remove this once we build using preview 6 SDK. -->
<_IsTrimmingEnabled>false</_IsTrimmingEnabled>
<!-- Same fix for preview 6 SDK. -->
Copy link
Member

@sbomer sbomer Aug 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we still need to set _RequiresILLinkPack when using the P6 SDK- that hasn't changed.

Copy link
Member Author

@akoeplinger akoeplinger Aug 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and it should work in P7? we're bumping to that in #90014 so we can just wait a bit.

Copy link
Member

@sbomer sbomer Aug 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we'll still need to set it to avoid depending on the SDK's logic to restore ILLink. We can remove the preview 6 comment.

@akoeplinger
Copy link
Member Author

akoeplinger commented Aug 23, 2023

Superseded by #90517

@akoeplinger akoeplinger deleted the akoeplinger-patch-1 branch August 23, 2023 09:17
@ghost ghost locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sbomer sbomer sbomer left review comments

@ViktorHofer ViktorHofer Awaiting requested review from ViktorHofer

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

@akoeplinger akoeplinger

Labels

area-Infrastructure-libraries linkable-framework Issues associated with delivering a linker friendly framework

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@akoeplinger @sbomer