Skip to content

Make --skip-unresolved the default when not running from SDK #90512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbomer merged 7 commits into from
Sep 1, 2023
Merged

Make --skip-unresolved the default when not running from SDK #90512

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9d5f279
Make `--skip-unresolved` the default when not running from SDK
Youssef1313 Aug 14, 2023
a222799
Fix command-line doc
Youssef1313 Aug 14, 2023
1152d6f
Update NullableOnConstraints test
Youssef1313 Aug 17, 2023
6216c05
chore: Update CanPreserveNullableCustomOperators test
Youssef1313 Aug 17, 2023
70ef17f
Remove `--skip-unresolved` from targets as it's the default now in co…
Youssef1313 Aug 17, 2023
1bbf32c
Merge remote-tracking branch 'origin/main' into pr/Youssef1313/90512-2
sbomer Sep 1, 2023
8a99fab
Fix tests that check --skip-unresolved false behavior
sbomer Sep 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/tools/illink/src/ILLink.Tasks/build/Microsoft.NET.ILLink.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,6 @@ Copyright (c) .NET Foundation. All rights reserved.

<PropertyGroup>
<ILLinkTreatWarningsAsErrors Condition=" '$(ILLinkTreatWarningsAsErrors)' == '' ">$(TreatWarningsAsErrors)</ILLinkTreatWarningsAsErrors>
<_ExtraTrimmerArgs>--skip-unresolved true $(_ExtraTrimmerArgs)</_ExtraTrimmerArgs>
<TrimmerSingleWarn Condition=" '$(TrimmerSingleWarn)' == '' ">true</TrimmerSingleWarn>
</PropertyGroup>

Expand Down
2 changes: 1 addition & 1 deletion src/tools/illink/src/linker/Linker/Driver.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1336,7 +1336,7 @@ static void Usage ()
Console.WriteLine (" --custom-data KEY=VALUE Populates context data set with user specified key-value pair");
Console.WriteLine (" --deterministic Produce a deterministic output for modified assemblies");
Console.WriteLine (" --ignore-descriptors Skips reading embedded descriptors (short -z). Defaults to false");
Console.WriteLine (" --skip-unresolved Ignore unresolved types, methods, and assemblies. Defaults to false");
Console.WriteLine (" --skip-unresolved Ignore unresolved types, methods, and assemblies. Defaults to true");
Console.WriteLine (" --output-pinvokes PATH Output a JSON file with all modules and entry points of the P/Invokes found");
Console.WriteLine (" --verbose Log messages indicating progress and warnings");
Console.WriteLine (" --nowarn WARN Disable specific warning messages");
Expand Down
2 changes: 1 addition & 1 deletion src/tools/illink/src/linker/Linker/LinkContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ public Pipeline Pipeline {

public bool KeepMembersForDebugger { get; set; } = true;

public bool IgnoreUnresolved { get; set; }
public bool IgnoreUnresolved { get; set; } = true;

public bool EnableReducedTracing { get; set; }

Expand Down
2 changes: 1 addition & 1 deletion ...ools/illink/test/Mono.Linker.Tests.Cases/Attributes/OnlyKeepUsed/NullableOnConstraints.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,4 +45,4 @@ interface I
class C<T> where T : I?
{
}
}
}
1 change: 1 addition & 0 deletions src/tools/illink/test/Mono.Linker.Tests.Cases/References/MissingReferenceInUnusedCodePath.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ namespace Mono.Linker.Tests.Cases.References;
[NoLinkedOutput]
[SetupCompileBefore ("missing.dll", new[] { "Dependencies/MissingAssembly.cs" })]
[DeleteBefore ("missing.dll")]
[SetupLinkerArgument ("--skip-unresolved", "false")]
public class MissingReferenceInUnusedCodePath
{
public static void Main ()
Expand Down
1 change: 1 addition & 0 deletions src/tools/illink/test/Mono.Linker.Tests.Cases/References/MissingReferenceInUsedCodePath.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ namespace Mono.Linker.Tests.Cases.References;
[NoLinkedOutput]
[SetupCompileBefore ("missing.dll", new[] { "Dependencies/MissingAssembly.cs" })]
[DeleteBefore ("missing.dll")]
[SetupLinkerArgument ("--skip-unresolved", "false")]
public class MissingReferenceInUsedCodePath
{
public static void Main ()
Expand Down