Remove quotes from language versions in source gen diagnostics. #90720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-meta Issue DetailsFollowing up on #90654 (comment) this updates the diagnostic messages so that quotes are never used on language versions.
|
stephentoub
approved these changes
Aug 17, 2023
eiriktsarpalis
added a commit
that referenced
this pull request
Aug 17, 2023
carlossanlop
pushed a commit
that referenced
this pull request
Aug 17, 2023
#90709) * Limit language version on Logger and Options source gens * Exclude test in browser * Address the feedback * Fix Json test and apply more feedback * Remove quotes from language versions in source gen diagnostics. (#90720) --------- Co-authored-by: Tarek Mahmoud Sayed <tarekms@microsoft.com> Co-authored-by: Eirik Tsarpalis <eirik.tsarpalis@gmail.com>
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #90654 (comment) this updates the diagnostic messages so that quotes are never used on language versions.
If it gets merged we should cherry pick the changes in #90709.