[Docs][tests] Add Mono Profiled AOT Functional Test and doc #90959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdh1418
requested review from
akoeplinger,
lambdageek,
lateralusX and
steveisok
ghost
added
the
|
Tagging subscribers to this area: @directhex Issue DetailsThis PR looks to add documentation surrounding Mono's dotnet-pgo based Profiled AOT story enabled through #69512. It also adds an Android functional test to test the Mono AOT Compiler ingesting a
|
akoeplinger
approved these changes
Aug 23, 2023
| @@ -0,0 +1 @@ | |||
| See [Profiled Ahead-Of-Time Compilation on Mono](https://github.com/dotnet/runtime/docs/design/mono/profiled-aot.md#android----running-through-the-android-profiled-aot-functional-test) No newline at end of file | |||
Member
There was a problem hiding this comment.
I think that link won't work since it's missing the branch name. Instead you can just use a relative link:
Suggested change
| See [Profiled Ahead-Of-Time Compilation on Mono](https://github.com/dotnet/runtime/docs/design/mono/profiled-aot.md#android----running-through-the-android-profiled-aot-functional-test) | |
| See [Profiled Ahead-Of-Time Compilation on Mono](/docs/design/mono/profiled-aot.md#android----running-through-the-android-profiled-aot-functional-test) |
|
|
||
| <!-- Profiled AOT with .mibc--> | ||
| <PropertyGroup> | ||
| <ProfiledAOTProfilePaths>$(MSBuildThisFileDirectory)\adeapt.mibc</ProfiledAOTProfilePaths> |
Member
There was a problem hiding this comment.
you might want to call this just test.mibc and test.nettrace so it is clearer that these are test assets.
Member
Author
|
/azp run runtime-android |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run runtime-android |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mdh1418
force-pushed
the
mono_profiled_aot_story
branch
from
4dc3a06 to
695e526
Compare
Member
Author
|
/azp run runtime-android |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Aug 23, 2023
Member
Author
|
Test failure is issue #88843 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR looks to add documentation surrounding Mono's dotnet-pgo based Profiled AOT story enabled through #69512. It also adds an Android functional test to test the Mono AOT Compiler ingesting a
.mibcprofile and a.nettrace.