Skip to content

Add test for using fallback RID when reading an empty RID graph#91040

Merged
elinor-fung merged 1 commit intodotnet:mainfrom
elinor-fung:emptyRidGraph-test
Aug 24, 2023
Merged

Add test for using fallback RID when reading an empty RID graph#91040
elinor-fung merged 1 commit intodotnet:mainfrom
elinor-fung:emptyRidGraph-test

Conversation

@elinor-fung
Copy link
Member

When there is no RID graph and the host is configured to use the RID graph, it will discard the computed machine RID (because it is not in the RID graph) and use the fallback RID (compile-time define) to look for assets. This adds a test that exact matches to the fallback RID should be resolved in that case.

Fixes #86250

@ghost ghost added the area-Host label Aug 24, 2023
@ghost ghost assigned elinor-fung Aug 24, 2023
@ghost
Copy link

ghost commented Aug 24, 2023

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

Issue Details

When there is no RID graph and the host is configured to use the RID graph, it will discard the computed machine RID (because it is not in the RID graph) and use the fallback RID (compile-time define) to look for assets. This adds a test that exact matches to the fallback RID should be resolved in that case.

Fixes #86250

Author: elinor-fung
Assignees: -
Labels:

area-Host

Milestone: -

Copy link
Member

@vitek-karas vitek-karas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@elinor-fung elinor-fung merged commit cc70553 into dotnet:main Aug 24, 2023
@elinor-fung elinor-fung deleted the emptyRidGraph-test branch August 24, 2023 17:30
@ghost ghost locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add test for successfully matching current RID when reading an empty RID graph

2 participants