[release/6.0-staging] [Mono] Fix offset calculation for nested struct, when pinvoke is enabled #91424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanyang-mono
requested review from
SamMonoRT,
lambdageek and
vargaz
as code owners
ghost
added
the
needs-area-label
fanyang-mono
added
area-Codegen-JIT-mono
area-Codegen-AOT-mono
area-Interop-mono
Servicing-consider
fanyang-mono
changed the title
Member
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
Contributor
|
@fanyang-mono if this is ready, can you please request a code review sign-off and also send an email to Tactics requesting approval? Also, do you see any CI failures related to this change? September 10th is the code complete date for the October Release. cc @SamMonoRT |
lambdageek
approved these changes
Sep 1, 2023
SamMonoRT
approved these changes
Sep 1, 2023
Member
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
Member
Author
|
Approved via Tactics Email. |
fanyang-mono
added
Servicing-approved
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #91292 to release/6.0-staging
/cc @fanyang-mono
Customer Impact
Prior to this change, the offset of fields was calculated incorrectly for nested struct when PInvoke is enabled. One of the Android customers hit an assertion when build an app.
Testing
Added a new test, which passed on CI.
Validated customer's use case locally. It works correctly now.
Risk
Low risk.