Replace newline characters in NoWarn #92010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
area-NativeAOT-coreclr
community-contribution
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsWhen writing the rsp file, we should not emit the newline characters due to $(NoWarn) evaluation because for one, it breaks response file parsing. This is a simplest fix for #91965.
|
This was referenced Sep 13, 2023
jkotas
reviewed
Sep 13, 2023
jkotas
approved these changes
Sep 14, 2023
Member
jkotas
left a comment
jkotas
left a comment
There was a problem hiding this comment.
LGTM.
@dotnet/ilc-contrib Any concerns?
Member
|
/backport to release/8.0 |
Contributor
|
Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6186270741 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When writing the rsp file, we should not emit the newline characters due to $(NoWarn) evaluation because for one, it breaks response file parsing. Alternative (or additional) fix is to make parsing handle multi-line values among other things, which is a bit involved.
This is a simplest fix for #91965.