[release/8.0-rc2] [browser] Fix SIMD+EH check #92422

github-actions · 2023-09-21T17:31:54Z

Backport of #92348 to release/8.0

Customer Impact

Fix support for running WASM application on older browsers without SIMD or EH.
The app itself is build correctly, but additional check on runtime was incorrect.

Testing

Manual. Automated test TBD

Risk

Low

IMPORTANT: If this backport is for a servicing release, please verify that:

The PR target branch is release/X.0-staging, not release/X.0.
If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

…nals build 20230919.1 (#92340) Microsoft.SourceBuild.Intermediate.source-build-externals From Version 8.0.0-alpha.1.23468.1 -> To Version 8.0.0-alpha.1.23469.1 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

Picking the update from #92320 to here, to avoid the overlap.

In case of a version like `8.0.100-rtm.23470.1`, we incorrectly extracted `-rtm.23470` instead of `-rtm`, which resulted in trying to install package named `Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100-rtm.23470` instead of `Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100-rtm`.

…c2-to-release/8.0 [automated] Merge branch 'release/8.0-rc2' => 'release/8.0'

* Update dependencies from https://github.com/dotnet/roslyn build 20230919.3 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23469.1 -> To Version 4.8.0-3.23469.3 * Update dependencies from https://github.com/dotnet/roslyn build 20230919.4 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23469.1 -> To Version 4.8.0-3.23469.4 * Update dependencies from https://github.com/dotnet/roslyn build 20230919.6 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23469.1 -> To Version 4.8.0-3.23469.6 * Update dependencies from https://github.com/dotnet/roslyn build 20230919.7 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23469.1 -> To Version 4.8.0-3.23469.7 * Update dependencies from https://github.com/dotnet/roslyn build 20230919.9 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23469.1 -> To Version 4.8.0-3.23469.9 * Update dependencies from https://github.com/dotnet/roslyn build 20230919.10 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23469.1 -> To Version 4.8.0-3.23469.10 * Update dependencies from https://github.com/dotnet/roslyn build 20230919.11 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23469.1 -> To Version 4.8.0-3.23469.11 * Update dependencies from https://github.com/dotnet/roslyn build 20230920.1 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23469.1 -> To Version 4.8.0-3.23470.1 * Update dependencies from https://github.com/dotnet/roslyn build 20230920.2 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23469.1 -> To Version 4.8.0-3.23470.2 * Update dependencies from https://github.com/dotnet/roslyn build 20230920.4 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23469.1 -> To Version 4.8.0-3.23470.4 * Update dependencies from https://github.com/dotnet/roslyn build 20230920.5 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23469.1 -> To Version 4.8.0-3.23470.5 * Update dependencies from https://github.com/dotnet/roslyn build 20230920.7 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23469.1 -> To Version 4.8.0-3.23470.7 * Update dependencies from https://github.com/dotnet/roslyn build 20230920.8 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23469.1 -> To Version 4.8.0-3.23470.8 * Update dependencies from https://github.com/dotnet/roslyn build 20230920.10 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23469.1 -> To Version 4.8.0-3.23470.10 * Update dependencies from https://github.com/dotnet/roslyn build 20230920.6 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23469.1 -> To Version 4.8.0-3.23470.6 * Update dependencies from https://github.com/dotnet/roslyn build 20230920.12 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23469.1 -> To Version 4.8.0-3.23470.12 * Update dependencies from https://github.com/dotnet/roslyn build 20230921.1 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23469.1 -> To Version 4.8.0-3.23471.1 * Update dependencies from https://github.com/dotnet/roslyn build 20230921.2 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23469.1 -> To Version 4.8.0-3.23471.2 --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

… ready (onRuntimeInitializedAsync)

carlossanlop · 2023-09-21T17:54:59Z

@maraf @lewing this is targeting release/8.0. Is that intended? There's still time to merge into release/8.0-rc2. You can quickly change the target branch by editing the PR title (lots of people don't know about that feature so I always share it).

Regardless of the target branch, please fill out the template and send an email to Tactics requesting approval.

ghost · 2023-09-21T19:25:40Z

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #92348 to release/8.0

/cc @lewing @maraf

Customer Impact

Fix support for running WASM application on older browsers without SIMD or EH.
The app itself is build correctly, but additional check on runtime was incorrect.

Testing

Manual. Automated test TBD

Risk

Low

IMPORTANT: If this backport is for a servicing release, please verify that:

The PR target branch is release/X.0-staging, not release/X.0.
If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author:	github-actions[bot]
Assignees:	maraf
Labels:	`arch-wasm`, `area-System.Runtime.InteropServices.JavaScript`, `os-browser`
Milestone:	-

pavelsavara

TypeScript changes LGTM

radical · 2023-09-21T19:48:03Z

eng/Version.Details.xml

      <SourceBuild RepoName="cecil" ManagedOnly="true" />
    </Dependency>
-    <Dependency Name="Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport" Version="8.0.0-rc.2.23469.4">
+    <Dependency Name="Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport" Version="8.0.0-rtm.23470.1">


This needs to be changed from -rtm to -rc2 too.

radical · 2023-09-21T19:48:20Z

eng/Version.Details.xml

      <Sha>99168dcff56809205e7ef8530d1256f3a07fab1f</Sha>
    </Dependency>
-    <Dependency Name="Microsoft.Net.Compilers.Toolset" Version="4.8.0-3.23469.1">
+    <Dependency Name="Microsoft.Net.Compilers.Toolset" Version="4.8.0-3.23471.2">


Why are these being updated in this PR?

I suspect the target branch change caused this: the PR was initially targeting release/8.0.. Good catch.

If you don't mind, can you push the right fix to this PR so that we can get this merged sooner, @radical?

Actually hold on @radical - I think because the original branch itself was targeting release/8.0 it brought many more commits that are not wanted here, not just the ones you're pointing out. @pavelsavara can you please take care of it yourself? Reset your local branch to point to rc2, then cherry-pick your changes, and force push to this PR.

excellent catch!

carlossanlop · 2023-09-21T22:58:35Z

Thanks for resubmitting, @lewing.

dotnet-maestro bot and others added 10 commits September 20, 2023 09:30

Update dependencies from dotnet/emsdk

1361b18

Picking the update from #92320 to here, to avoid the overlap.

Merge pull request #92325 from dotnet-maestro-bot/merge/release/8.0-r…

df1cf0c

…c2-to-release/8.0 [automated] Merge branch 'release/8.0-rc2' => 'release/8.0'

Move simd+eh check after emcripten provided build time values

780aa4f

Call cwraps.mono_wasm_abort from runtimeHelpers.abort when cwraps are…

75c250f

… ready (onRuntimeInitializedAsync)

Assign early mono_wasm_exit and abort even earlier

cad253e

Fire feature check before awaiting wasm download, but await it after.

4259361

Whitespaces

1ae155f

github-actions bot requested review from kg, lewing and pavelsavara as code owners September 21, 2023 17:31

ghost added the area-System.Runtime.InteropServices.JavaScript label Sep 21, 2023

carlossanlop assigned maraf Sep 21, 2023

maraf changed the base branch from release/8.0 to release/8.0-rc2 September 21, 2023 19:22

maraf requested a review from radical as a code owner September 21, 2023 19:22

maraf added arch-wasm WebAssembly architecture os-browser Browser variant of arch-wasm labels Sep 21, 2023

maraf added this to the 8.0.0 milestone Sep 21, 2023

maraf changed the title ~~[release/8.0] [browser] Fix SIMD+EH check~~ [release/8.0-rc2] [browser] Fix SIMD+EH check Sep 21, 2023

pavelsavara approved these changes Sep 21, 2023

View reviewed changes

lewing added the Servicing-consider Issue for next servicing release review label Sep 21, 2023

radical reviewed Sep 21, 2023

View reviewed changes

carlossanlop added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Sep 21, 2023

lewing closed this Sep 21, 2023

carlossanlop deleted the backport/pr-92348-to-release/8.0 branch September 21, 2023 22:39

build-analysis bot mentioned this pull request Sep 22, 2023

System.Data.OleDb.Tests timeout in net48 x86 Release leg #87783

Closed

ghost locked as resolved and limited conversation to collaborators Oct 22, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[release/8.0-rc2] [browser] Fix SIMD+EH check #92422

[release/8.0-rc2] [browser] Fix SIMD+EH check #92422

Uh oh!

github-actions bot commented Sep 21, 2023 •

edited by maraf

Loading

Uh oh!

carlossanlop commented Sep 21, 2023

Uh oh!

ghost commented Sep 21, 2023

Customer Impact

Testing

Risk

Uh oh!

pavelsavara left a comment

Uh oh!

radical Sep 21, 2023

Uh oh!

radical Sep 21, 2023

Uh oh!

carlossanlop Sep 21, 2023

Uh oh!

carlossanlop Sep 21, 2023

Uh oh!

radical Sep 21, 2023

Uh oh!

carlossanlop commented Sep 21, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

[release/8.0-rc2] [browser] Fix SIMD+EH check #92422

[release/8.0-rc2] [browser] Fix SIMD+EH check #92422

Uh oh!

Conversation

github-actions bot commented Sep 21, 2023 • edited by maraf Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Customer Impact

Testing

Risk

Uh oh!

carlossanlop commented Sep 21, 2023

Uh oh!

ghost commented Sep 21, 2023

Customer Impact

Testing

Risk

Uh oh!

pavelsavara left a comment

Choose a reason for hiding this comment

Uh oh!

radical Sep 21, 2023

Choose a reason for hiding this comment

Uh oh!

radical Sep 21, 2023

Choose a reason for hiding this comment

Uh oh!

carlossanlop Sep 21, 2023

Choose a reason for hiding this comment

Uh oh!

carlossanlop Sep 21, 2023

Choose a reason for hiding this comment

Uh oh!

radical Sep 21, 2023

Choose a reason for hiding this comment

Uh oh!

carlossanlop commented Sep 21, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

github-actions bot commented Sep 21, 2023 •

edited by maraf

Loading