Reenable pragma suppressions for config binder gen (+ JSON) #92740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
layomia
commented
Sep 27, 2023
layomia
commented
- Prototyping a fix. They were disabled in Make config binding gen incremental #89587, which (temporarily, hopefully) sacrificed the UX over favor of incremental generation.
- Workaround till we implement a separate analyzer to handle diagnostics (Address diagnostic issues in runtime incremental source generators #92509).
- Proposing to address in 8.0 for config binder since all diagnostics are issued in source.
|
Tagging subscribers to this area: @dotnet/area-extensions-configuration Issue Details
|
| Location trimmedLocation = Location.Create(sourceLocation.SourceTree?.FilePath ?? "", sourceLocation.SourceSpan, sourceLocation.GetLineSpan().Span); | ||
|
|
||
| if (sourceLocation.IsInSource && | ||
| !trimmedLocation.IsInSource && |
Member
There was a problem hiding this comment.
What determines whether trimmedLocation.IsInSource is true?
| try | ||
| { | ||
| FieldInfo[] fields = typeof(Location).GetFields(BindingFlags.NonPublic); | ||
| info = typeof(Location).GetField("<SourceTree>k__BackingField", BindingFlags.NonPublic | BindingFlags.Instance); |
Member
There was a problem hiding this comment.
I'm not comfortable taking a dependency on this type of implementation detail, particularly in product code. We should instead work with @dotnet/roslyn to come up with a better solution for storing Location instances in incremental values that doesn't encapsulate the Compilation instance.
cc @stephentoub
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.