Skip to content

[release/8.0] Make a copy of assembly path. #93253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carlossanlop merged 3 commits into from
Oct 12, 2023
Merged

[release/8.0] Make a copy of assembly path. #93253

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d995abf
Make a copy of assembly path.
AaronRobinsonMSFT Oct 9, 2023
a38c3d8
Use correct C++.
AaronRobinsonMSFT Oct 9, 2023
2f84988
Use copy ctor explicitly
AaronRobinsonMSFT Oct 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/coreclr/vm/perfinfo.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ void PerfInfo::LogImage(PEAssembly* pPEAssembly, CHAR* guid)
PRECONDITION(guid != nullptr);
} CONTRACTL_END;

SString value;
const SString& path = pPEAssembly->GetPath();
// Nothing to log if the assembly path isn't present.
SString path{ pPEAssembly->GetPath() };
if (path.IsEmpty())
{
return;
Expand All @@ -49,12 +49,11 @@ void PerfInfo::LogImage(PEAssembly* pPEAssembly, CHAR* guid)
}
}

SString value;
value.Printf("%s%c%s%c%p", path.GetUTF8(), sDelimiter, guid, sDelimiter, baseAddr);

SString command;
command.Printf("%s", "ImageLoad");
SString command{ SString::Literal, "ImageLoad" };
WriteLine(command, value);

}

// Writes a command line, with "type" being the type of command, with "value" as the command's corresponding instructions/values. This is to be used to log specific information, e.g. LogImage
Expand Down