Move most of the remaining Strong Name code to internal to the C++ file and remove duplicate validation#95536
Merged
jkoritzinsky merged 10 commits intodotnet:mainfrom Dec 6, 2023
Merged
Conversation
ghost
assigned
danmoseley
reviewed
Dec 2, 2023
jkotas
reviewed
Dec 3, 2023
jkotas
reviewed
Dec 3, 2023
… that Arcade includes to catch all assemblies we ship.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove all function prototypes for functions only called in
strongnameinternal.cppfromstrongnameinternal.h.Remove duplicate validation in
StrongNameTokenFromPublicKey. These validation checks were already done inStrongNameIsValidPublicKey.Remove extraneous
#includeof one of the key headers inmethodtablebuilder.cpp.