-
Notifications
You must be signed in to change notification settings - Fork 5.3k
JIT: refactor CSE heuristics #95705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JIT: refactor CSE heuristics #95705
Conversation
Split the heuristics into a common base class and (currently) two derived classes, one for normal CSEs and another for random CSEs.
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsSplit the heuristics into a common base class and (currently) two derived classes, one for normal CSEs and another for random CSEs.
|
|
Was expecting no diffs, but have few, let me dig in. |
|
Diffs come from slight changes to how the CSE stress works
I think the new behavior is preferable. Will run jitstress to see if it causes any issues. |
|
/azp run coreclr-runtime jitstress |
|
No pipelines are associated with this pull request. |
|
/azp run runtime-coreclr jitstress |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@jakobbotsch PTAL Passed jit stress pre merge commit. |
jakobbotsch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, didn't go into too much detail under the assumption that this is more or less mechanical...
Split the heuristics into a common base class and (currently) two derived classes, one for normal CSEs and another for random CSEs.