Skip to content

Conversation

@AndyAyersMS
Copy link
Member

Split the heuristics into a common base class and (currently) two derived classes, one for normal CSEs and another for random CSEs.

Split the heuristics into a common base class and (currently) two
derived classes, one for normal CSEs and another for random CSEs.
@ghost ghost assigned AndyAyersMS Dec 6, 2023
@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Dec 6, 2023
@ghost
Copy link

ghost commented Dec 6, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Split the heuristics into a common base class and (currently) two derived classes, one for normal CSEs and another for random CSEs.

Author: AndyAyersMS
Assignees: AndyAyersMS
Labels:

area-CodeGen-coreclr

Milestone: -

@AndyAyersMS
Copy link
Member Author

Was expecting no diffs, but have few, let me dig in.

@AndyAyersMS
Copy link
Member Author

Diffs come from slight changes to how the CSE stress works

  • previously it could only accept rejectable candidates, now it may reject acceptable candidates
  • random heuristic no longer sorts CSEs, so candidate order has changed; the RNG is stateful, so we get different random values for each candidate
  • we have a handful of coreclr tests that enable jit stress

I think the new behavior is preferable. Will run jitstress to see if it causes any issues.

@AndyAyersMS
Copy link
Member Author

/azp run coreclr-runtime jitstress

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@AndyAyersMS
Copy link
Member Author

/azp run runtime-coreclr jitstress

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@AndyAyersMS AndyAyersMS marked this pull request as ready for review December 7, 2023 15:47
@AndyAyersMS
Copy link
Member Author

@jakobbotsch PTAL
cc @dotnet/jit-contrib

Passed jit stress pre merge commit.

Copy link
Member

@jakobbotsch jakobbotsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, didn't go into too much detail under the assumption that this is more or less mechanical...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants