JIT: Fix OSR DFS assert, and update entry BB for try regions #95871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is nothing that stops an edge into the original entry BB from existing, so this assert is overzealous. The asserting case, however, was because of `fgNormalizeEH` not taking care to update `fgEntryBB`; also fix that.
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsThere is nothing that stops an edge into the original entry BB from existing, so this assert is overzealous. The asserting case, however, was because of
|
Member
Author
|
/azp run runtime-coreclr libraries-pgo |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Dec 11, 2023
Member
Author
|
cc @dotnet/jit-contrib PTAL @AndyAyersMS Looks like we still have some libraries-pgo failures, but from the assert it looks like #95845 will fix them. |
AndyAyersMS
approved these changes
Dec 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is nothing that stops an edge into the original entry BB from existing, so this assert is overzealous.
The asserting case, however, was because of
fgNormalizeEHnot taking care to updatefgEntryBB; also fix that.