Skip to content

Add ActiveIssue Annotations to Failing TestReadyToRun Tests and Reenable the Executables #96721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ivdiazsa merged 11 commits into from
Jan 11, 2024
Merged

Add ActiveIssue Annotations to Failing TestReadyToRun Tests and Reenable the Executables #96721

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
81dbaa8
Add "ActiveIssue" annotation placeholders to the failing tests, and
ivdiazsa Jan 9, 2024
41e254e
Added "ActiveIssue" annotation to failing Threading test.
ivdiazsa Jan 9, 2024
0e72946
Added the ActiveIssue annotation to AppDomain.cs
ivdiazsa Jan 9, 2024
7c8d940
Added the ActiveIssue template in FileSystemWatcher.File.Move.cs
ivdiazsa Jan 9, 2024
86f1764
Commented out an ActiveIssue annotation because I need to check on
ivdiazsa Jan 9, 2024
74f3077
Reenabled another failing test because I need to see it in CI.
ivdiazsa Jan 10, 2024
99275dd
Yet another test being weird...
ivdiazsa Jan 10, 2024
135fb8d
Merge branch 'main' into lost-woods
ivdiazsa Jan 10, 2024
4d8e6db
Disabled some Serialization tests after confirming in CI that they in…
ivdiazsa Jan 10, 2024
d3c58d6
Merge branch 'main' into lost-woods
ivdiazsa Jan 10, 2024
f49deba
Removed unneeded? commented out ActiveIssue annotation.
ivdiazsa Jan 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/libraries/Microsoft.XmlSerializer.Generator/tests/SGenTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ namespace Microsoft.XmlSerializer.Generator.Tests
public static class SgenTests
{
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/96796", typeof(PlatformDetection), nameof(PlatformDetection.IsReadyToRunCompiled))]
public static void SgenCommandTest()
{
/*
Expand Down
1 change: 1 addition & 0 deletions src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.File.Move.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,7 @@ private void FileMove_DifferentWatchedDirectory(WatcherChangeTypes eventType)
}
}

[ActiveIssue("https://github.com/dotnet/runtime/issues/96728", typeof(PlatformDetection), nameof(PlatformDetection.IsReadyToRunCompiled))]
private void FileMove_FromWatchedToUnwatched(WatcherChangeTypes eventType)
{
string dir_watched = CreateTestDirectory(TestDirectory, "dir_watched");
Expand Down
1 change: 1 addition & 0 deletions src/libraries/System.Private.Xml/tests/XmlSerializer/XmlSerializerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2101,6 +2101,7 @@ public static void Xml_TypeWithSpecialCharacterInStringMember()
[SkipOnPlatform(TestPlatforms.Browser, "AssemblyDependencyResolver not supported in wasm")]
#endif
[ActiveIssue("34072", TestRuntimes.Mono)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/96799", typeof(PlatformDetection), nameof(PlatformDetection.IsReadyToRunCompiled))]
public static void Xml_TypeInCollectibleALC()
{
ExecuteAndUnload("SerializableAssembly.dll", "SerializationTypes.SimpleType", out var weakRef);
Expand Down
1 change: 1 addition & 0 deletions src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/AppDomainTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ public void RelativeSearchPath_Is_Null()

[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.HasHostExecutable))]
[SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.Android | TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst, "The dotnet sdk will not be available on these platforms")]
[ActiveIssue("https://github.com/dotnet/runtime/issues/96727", typeof(PlatformDetection), nameof(PlatformDetection.IsReadyToRunCompiled))]
public void TargetFrameworkTest()
{
const int ExpectedExitCode = 0;
Expand Down
1 change: 1 addition & 0 deletions src/libraries/System.Threading.Thread/tests/ThreadTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,7 @@ public static IEnumerable<object[]> ApartmentStateTest_MemberData()
[InlineData("DefaultApartmentStateMain.exe", "GetApartmentStateTest")]
[InlineData("DefaultApartmentStateMain.exe", "SetApartmentStateTest")]
[ActiveIssue("https://github.com/dotnet/runtime/issues/34543", TestPlatforms.Windows, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/86722", typeof(PlatformDetection), nameof(PlatformDetection.IsReadyToRunCompiled))]
public static void ApartmentState_AttributePresent(string appName, string testName)
{
var psi = new ProcessStartInfo();
Expand Down
9 changes: 0 additions & 9 deletions src/libraries/tests.proj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -618,20 +618,11 @@
Tracking Issue for this work item: https://github.com/dotnet/runtime/issues/95928
-->
<ItemGroup Condition="'$(TestReadyToRun)' == 'true'">
<ProjectExclusions Include="$(MSBuildThisFileDirectory)Microsoft.Extensions.DependencyInjection/tests/DI.External.Tests/Microsoft.Extensions.DependencyInjection.ExternalContainers.Tests.csproj" />
<ProjectExclusions Include="$(MSBuildThisFileDirectory)Microsoft.XmlSerializer.Generator/tests/Microsoft.XmlSerializer.Generator.Tests.csproj" />
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.ComponentModel.Composition/tests/System.ComponentModel.Composition.Tests.csproj" />
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Composition/tests/System.Composition.Tests.csproj" />
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Console/tests/System.Console.Tests.csproj" />
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Runtime/tests/System.Dynamic.Runtime.Tests/System.Dynamic.Runtime.Tests.csproj" />
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.IO.FileSystem.Watcher/tests/System.IO.FileSystem.Watcher.Tests.csproj" />
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Runtime/tests/System.Reflection.Tests/System.Reflection.Tests.csproj" />
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Reflection.TypeExtensions/tests/System.Reflection.TypeExtensions.Tests.csproj" />
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Runtime/tests/System.Runtime.Extensions.Tests/System.Runtime.Extensions.Tests.csproj" />
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Runtime.Loader/tests/DefaultContext/System.Runtime.Loader.DefaultContext.Tests.csproj" />
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Runtime.Loader/tests/System.Runtime.Loader.Tests.csproj" />
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Text.RegularExpressions/tests/FunctionalTests/System.Text.RegularExpressions.Tests.csproj" />
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Threading.Thread/tests/System.Threading.Thread.Tests.csproj" />
</ItemGroup>

<ItemGroup>
Expand Down