Skip to content

Type test List<T> in Enumerable.SequenceEquals and forward to MemoryExtensions.SequenceEqual(span...) #97004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephentoub merged 2 commits into from
Jan 18, 2024
Merged

Type test List<T> in Enumerable.SequenceEquals and forward to MemoryExtensions.SequenceEqual(span...) #97004

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1aa701a
Use .TryGetSpan on sequences instead of type checks to forward sequen…
neon-sunset Jan 16, 2024
281b136
Merge branch 'main' into sequenceequal-list
neon-sunset Jan 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/libraries/System.Linq/src/System/Linq/SequenceEqual.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,9 @@ public static bool SequenceEqual<TSource>(this IEnumerable<TSource> first, IEnum

if (first is ICollection<TSource> firstCol && second is ICollection<TSource> secondCol)
{
if (first is TSource[] firstArray && second is TSource[] secondArray)
if (first.TryGetSpan(out ReadOnlySpan<TSource> firstSpan) && second.TryGetSpan(out ReadOnlySpan<TSource> secondSpan))
{
return ((ReadOnlySpan<TSource>)firstArray).SequenceEqual(secondArray, comparer);
return firstSpan.SequenceEqual(secondSpan, comparer);
}

if (firstCol.Count != secondCol.Count)
Expand Down