Skip to content

Convert Array.CopySlow to managed #97202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AaronRobinsonMSFT merged 25 commits into from
Jan 26, 2024
Merged

Convert Array.CopySlow to managed #97202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
6ee9d7b
Body of CopySlow and setup QCall for CanAssignArrayType
huoyaoyuan Jan 18, 2024
220ba57
UnBoxEachElement
huoyaoyuan Jan 18, 2024
a7fa4db
BoxEachElement
huoyaoyuan Jan 18, 2024
887c54a
CastCheckEachElement
huoyaoyuan Jan 18, 2024
43b99ce
Simplify Unsafe.As
huoyaoyuan Jan 18, 2024
ad0e7f6
PrimitiveWiden with scalar implementation
huoyaoyuan Jan 19, 2024
7ee8f42
Remove native implementation
huoyaoyuan Jan 19, 2024
2e63054
Suppress trimming warning
huoyaoyuan Jan 19, 2024
8062ec4
Fix GC mode for CanAssignArrayType
huoyaoyuan Jan 19, 2024
dafbc24
Rename each routine
huoyaoyuan Jan 20, 2024
41f3fa8
Reduce code bloat of generic math
huoyaoyuan Jan 21, 2024
5456631
GC barrier
huoyaoyuan Jan 21, 2024
0dddd00
Unbox helper for nullable
huoyaoyuan Jan 21, 2024
4965cb5
Throw InvalidCastException
huoyaoyuan Jan 22, 2024
dc4724d
Simplify
huoyaoyuan Jan 22, 2024
879c3cf
Add asserts
huoyaoyuan Jan 22, 2024
17c9b23
Try remove cctor run
huoyaoyuan Jan 22, 2024
79ff323
Use void* for ElementType
huoyaoyuan Jan 24, 2024
491dd2e
UnBoxEachElement only allows exact type match
huoyaoyuan Jan 24, 2024
c96d08d
Fix MD array
huoyaoyuan Jan 25, 2024
c27846b
Nit
huoyaoyuan Jan 25, 2024
224adf5
Move Unbox_Nullable to RuntimeHelpers
huoyaoyuan Jan 25, 2024
d67643e
Fix PrimitiveWiden
huoyaoyuan Jan 25, 2024
297d515
Cleanup native code
huoyaoyuan Jan 26, 2024
4f442b1
Update src/coreclr/classlibnative/bcltype/arraynative.cpp
huoyaoyuan Jan 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
299 changes: 297 additions & 2 deletions src/coreclr/System.Private.CoreLib/src/System/Array.CoreCLR.cs
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion src/coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/CastHelpers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ internal static unsafe class CastHelpers
[DebuggerHidden]
[StackTraceHidden]
[DebuggerStepThrough]
private static object? ChkCastAny(void* toTypeHnd, object? obj)
internal static object? ChkCastAny(void* toTypeHnd, object? obj)
{
CastResult result;

Expand Down
3 changes: 3 additions & 0 deletions ...eclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/RuntimeHelpers.CoreCLR.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,6 +301,9 @@ internal static unsafe bool ObjectHasComponentSize(object obj)
[MethodImpl(MethodImplOptions.InternalCall)]
internal static extern unsafe object? Box(MethodTable* methodTable, ref byte data);

[MethodImpl(MethodImplOptions.InternalCall)]
internal static extern unsafe void Unbox_Nullable(ref byte destination, MethodTable* toTypeHnd, object? obj);

// Given an object reference, returns its MethodTable*.
//
// WARNING: The caller has to ensure that MethodTable* does not get unloaded. The most robust way
Expand Down
Loading