Skip to content

Conversation

@carlossanlop
Copy link
Contributor

@carlossanlop carlossanlop commented Jan 22, 2024

I intend to merge this PR before the snap.

After the snap, I'll submit an additional PR to point main to Preview 2.

I'm testing this works by locally building and then packing an in-box assembly to confirm the correct branding is indicated in the generated package.

Confirmed it's working:

dotnet pack src/libraries/System.Formats.Asn1/src/System.Formats.Asn1.csproj /p:OfficialBuild=true /p:ContinuousIntegrationBuild=true

Output:

Successfully created package 
'C:\Users\calope\source\repos\runtime\artifacts\packages\Release\Shipping\System.Formats.Asn1.9.0.0-preview.1.24072.1.nupkg'.
Successfully created package 
'C:\Users\calope\source\repos\runtime\artifacts\packages\Release\Shipping\System.Formats.Asn1.9.0.0-preview.1.24072.1.symbols.nupkg'.

@ghost
Copy link

ghost commented Jan 22, 2024

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

I intend to merge this PR before the snap.

After the snap, I'll submit an additional PR to point main to Preview 2.

I'm testing this works by locally buildin then packing an in-box assembly to confirm the correct branding is indicated in the generated package.

Author: carlossanlop
Assignees: carlossanlop
Labels:

area-Infrastructure

Milestone: -

@carlossanlop carlossanlop merged commit 4ecb857 into dotnet:main Jan 22, 2024
@carlossanlop carlossanlop deleted the BrandingPreview1 branch January 22, 2024 22:58
tmds pushed a commit to tmds/runtime that referenced this pull request Jan 23, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Feb 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants