[release/9.0-preview1] [wasi/wasm] EmccCompile.cs: quote the compiler path#97428
Merged
carlossanlop merged 1 commit intorelease/9.0-preview1from Jan 24, 2024
Merged
Conversation
This broke in PR#95051 which changed the task to use a custom path to the compiler instead of using `emcc` from `PATH`. Fixes https://github.com/dotnet/AspNetCore-ManualTests/issues/2594 .
ghost
added
the
needs-area-label
lewing
approved these changes
Jan 23, 2024
lewing
added
Servicing-consider
Member
|
The hung land appears to be caused by #97044 but there is no way to flag it with build analysis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #97427 to release/9.0-preview1
/cc @radical
Customer Impact
This fixes a recent regression https://github.com/dotnet/AspNetCore-ManualTests/issues/2594 in the Wasm AOT builds where spaces in the full path to the compiler were not correctly escaped.
Regression
The regression was introduced when the WASI and browser builds were combined into a common set of targets.
Testing
Manual Testing
Risk
Very Low, adds quoting when invoking a compiler so that absolute paths to the compiler are properly supported.