JIT: Improve consistency around indir flags; directly copy flags in gtCloneExpr
#97541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gtCloneExpr` - Switch `GT_STORE_DYN_BLK` to be on the same plan as other indirs; add a `gtNewStoreDynBlkNode` and use `gtInitializeIndirNode` to set its flags correctly. Add support for it to `GenTree::SetIndirExceptionFlags`. Remove conservative flag setting from its constructor. - Fix propagation of `GTF_EXCEPT` from `GT_CMPXCHG`'s data source inside `GenTree::SetIndirExceptionFlags` - Set flags directly from the source node in `gtCloneExpr` Fix dotnet#97524
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue Details
Fix #97524
|
Diff results for #97541Throughput diffsThroughput diffs for linux/arm64 ran on windows/x64MinOpts (+0.00% to +0.01%)
Throughput diffs for linux/x64 ran on windows/x64MinOpts (+0.00% to +0.02%)
Throughput diffs for osx/arm64 ran on windows/x64MinOpts (+0.00% to +0.01%)
Throughput diffs for windows/arm64 ran on windows/x64MinOpts (+0.00% to +0.01%)
Throughput diffs for windows/x64 ran on windows/x64Overall (+0.01%)
MinOpts (+0.00% to +0.03%)
FullOpts (+0.01%)
Details here Throughput diffs for linux/arm ran on windows/x86Overall (+0.00% to +0.01%)
MinOpts (+0.00% to +0.02%)
FullOpts (+0.00% to +0.01%)
Throughput diffs for windows/x86 ran on windows/x86Overall (+0.01%)
MinOpts (+0.01% to +0.03%)
FullOpts (+0.00% to +0.01%)
Details here Throughput diffs for linux/arm64 ran on linux/x64Overall (+0.03% to +0.05%)
MinOpts (+0.00% to +0.08%)
FullOpts (+0.04% to +0.05%)
Throughput diffs for linux/x64 ran on linux/x64Overall (+0.03% to +0.06%)
MinOpts (+0.00% to +0.09%)
FullOpts (+0.04% to +0.06%)
Details here |
3 tasks
Member
Author
|
/azp run runtime-coreclr jitstress, runtime-coreclr libraries-jitstress, Fuzzlyn |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Member
Author
|
cc @dotnet/jit-contrib PTAL @EgorBo @SingleAccretion |
SingleAccretion
approved these changes
Jan 26, 2024
EgorBo
reviewed
Jan 26, 2024
| assert(data->IsInitVal() || data->OperIs(GT_IND)); | ||
|
|
||
| GenTreeStoreDynBlk* store = new (this, GT_STORE_DYN_BLK) GenTreeStoreDynBlk(addr, data, dynamicSize); | ||
| store->gtFlags |= GTF_ASG; |
Member
There was a problem hiding this comment.
nit: it's already set in GenTreeStoreDynBlk ctror
Member
Author
There was a problem hiding this comment.
I removed that in this PR (just to make it consistent with gtNewStoreBlkNode)
EgorBo
approved these changes
Jan 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GT_STORE_DYN_BLKto be on the same plan as other indirs; add agtNewStoreDynBlkNodeand usegtInitializeIndirNodeto set its flags correctly. Add support for it toGenTree::SetIndirExceptionFlags. Remove conservative flag setting from its constructor.GTF_EXCEPTfromGT_CMPXCHG's data source insideGenTree::SetIndirExceptionFlagsgtCloneExprFix #97524