Skip to content

Fix yaml parser error on runtime-wasm-perf.yml #98005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akoeplinger merged 1 commit into from
Feb 6, 2024
Merged

Fix yaml parser error on runtime-wasm-perf.yml #98005

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/pipelines/runtime-wasm-perf.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ extends:
runProfile: 'v8'
collectHelixLogsScript: ${{ variables._wasmCollectHelixLogsScript }}
onlySanityCheck: true
#perfForkToUse: - dummy change
#perfForkToUse: # dummy change
Copy link
Contributor

@carlossanlop carlossanlop Feb 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this line commented anyway?

Copy link
Contributor Author

@caaavik-msft caaavik-msft Feb 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I suspect there is a bug in the YAML parser used by Azure Pipelines because this specific '-' was causing the pipeline to fail parsing even though it was in a comment.

Copy link
Contributor Author

@caaavik-msft caaavik-msft Feb 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Contributor

@carlossanlop carlossanlop Feb 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see. Weird.

#url: https://github.com/radical/performance
#branch: fix-build
#downloadSpecificBuild:
Expand Down