WorkloadBuildTasks: fix sourcebuild #98138
Conversation
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsThis avoids trying to build the target for unrelated linux/sourcebuild
|
ghost
added
the
|
Started a build on the internal pipeline to confirm the fix. |
`WorkloadBuildTasks` project uses source generated regex, which requires the corresponding analyzer to be used. But for net8.0, in source build the prebuilt package does not have the analyzers which causes the build to fail like: `/__w/1/s/artifacts/sb/src/src/tasks/WorkloadBuildTasks/InstallWorkloadFromArtifacts.cs(61,38): error CS8795: Partial method 'InstallWorkloadFromArtifacts.bandVersionRegex()' must have an implementation part because it has accessibility modifiers. [/__w/1/s/artifacts/sb/src/src/tasks/WorkloadBuildTasks/WorkloadBuildTasks.csproj::TargetFramework=net8.0]` Since the net8.0 build for the task is needed only for the internal nuget being produced, we can skip the net8.0 build for source builds. Also, build WorkloadTest.Internal nuget only when building wasm
radical
force-pushed
the
workload-tests
branch
from
77fef32 to
7d59a04
Compare
radical
changed the title
ilonatommy
left a comment
ilonatommy
left a comment
There was a problem hiding this comment.
What is the definition of internal build vs. source build?
By "internal build" I meant build on an internal pipeline. And sourcebuild is a special build done completely from source for dotnet. |
3 participants
WorkloadBuildTasksproject uses source generated regex, which requiresthe corresponding analyzer to be used. But for net8.0, in source build
the prebuilt package does not have the analyzers which causes the build
to fail like:
/__w/1/s/artifacts/sb/src/src/tasks/WorkloadBuildTasks/InstallWorkloadFromArtifacts.cs(61,38): error CS8795: Partial method 'InstallWorkloadFromArtifacts.bandVersionRegex()' must have an implementation part because it has accessibility modifiers. [/__w/1/s/artifacts/sb/src/src/tasks/WorkloadBuildTasks/WorkloadBuildTasks.csproj::TargetFramework=net8.0]Since the net8.0 build for the task is needed only for the internal
nuget being produced, we can skip the net8.0 build for source builds.
Also, build WorkloadTest.Internal nuget only when building wasm.
Fixes #98130 .