[release/6.0-staging] Set assets manifest metadata for assets that get shipped with .NET release#98991
Merged
ViktorHofer merged 2 commits intodotnet:release/6.0-stagingfrom Mar 6, 2024
Conversation
…lease (dotnet#98824) * add metadata to manifest * set in ItemDefinitionGroup * remove from items * comment
* add property to publishing.props * rename to ProducesDotNetReleaseShippingAssets * Update Publishing.props --------- Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
ghost
added
the
Contributor
|
Friendly reminder that Monday March 11th is the Code Complete date for the April Release. Similar to the other changes in 7.0 and 8.0, can you please confirm this change is modifying the shipped assets? if it is, then it needs a Tactics approval. If it does not, then we can treat this as tell-mode. cc @ViktorHofer |
ViktorHofer
approved these changes
Mar 6, 2024
Member
ViktorHofer
left a comment
ViktorHofer
left a comment
There was a problem hiding this comment.
Tell-mode only. Doesn't change shipping assets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #98665 and #98824 to release/6.0-staging