SPMI: Project out fields for diffs information #99226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there are many diffs we are still loading all of them into memory, and in CI this can cause OOMs in these cases. Every row becomes a dictionary that has an extra copy of all column names, and with the new metrics work there are a lot of columns. Fix the problem by projecting out just what is necessary from each row.
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsWhen there are many diffs we are still loading all of them into memory, and in CI this can cause OOMs in these cases. Every row becomes a dictionary that has an extra copy of all column names, and with the new metrics work there are a lot of columns. Fix the problem by projecting out just what is necessary from each row. Should fix the superpmi-asmdiffs failures seen in #99116.
|
Member
Author
|
cc @dotnet/jit-contrib PTAL @kunalspathak |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are many diffs we are still loading all of them into memory, and in CI this can cause OOMs in these cases. Every row becomes a dictionary that has an extra copy of all column names, and with the new metrics work there are a lot of columns. Fix the problem by projecting out just what is necessary from each row.
Should fix the superpmi-asmdiffs failures seen in #95565.