Enable building tests with UseLocalAppHostPack=true#99354
Enable building tests with UseLocalAppHostPack=true#99354hoyosjs merged 1 commit intodotnet:mainfrom
Conversation
ghost
added
the
|
Tagging subscribers to this area: @hoyosjs Issue DetailsContributes to #97791
|
hoyosjs
left a comment
hoyosjs
left a comment
There was a problem hiding this comment.
Quick question. Otherwise, lgtm
| <Target Name="RestorePackage"> | ||
| <PropertyGroup> | ||
| <_ConfigurationProperties>/p:TargetOS=$(TargetOS) /p:TargetArchitecture=$(TargetArchitecture) /p:Configuration=$(Configuration) /p:CrossBuild=$(CrossBuild)</_ConfigurationProperties> | ||
| <_ConfigurationProperties Condition="'$(UseLocalAppHostPack)' == 'true'">$(_ConfigurationProperties) -p:EnableAppHostPackDownload=false -p:EnableTargetingPackDownload=false -p:EnableRuntimePackDownload=false</_ConfigurationProperties> |
There was a problem hiding this comment.
I guess the restore proj doesn't import eng/targetingpacks.targets? If it does it's enough to pass down the option, right?
There was a problem hiding this comment.
Yup, this can be removed when eng/targetingpacks.targets is imported. I kept this stopgap PR small. (I will try importing it and open a separate PR)
8 participants
Contributes to #97791
This is to enable building clr tests with -p:UseLocalAppHostPack=true (once the host subset is already built). This option is useful for community-supported platforms, which are listed in KnownFrameworkReference, KnownRuntimePack etc. in the dotnet/installer repo and we don't expect the official SDK to provide packs for these platforms.