Skip to content

JIT: initial work on general count reconstruction #99992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndyAyersMS merged 4 commits into from
Mar 26, 2024
Merged

JIT: initial work on general count reconstruction #99992

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b51cb47
JIT: initial work on general count reconstruction
AndyAyersMS Mar 18, 2024
6a2e2a6
check for self edges, add note about possible divergence
AndyAyersMS Mar 20, 2024
865e50a
repair instead of blend
AndyAyersMS Mar 23, 2024
60be72b
Merge branch 'main' into IterativeSolver
AndyAyersMS Mar 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions src/coreclr/jit/fgprofile.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2949,8 +2949,8 @@ PhaseStatus Compiler::fgIncorporateProfileData()
//
if (fgPgoHaveWeights && !dataIsGood)
{
JITDUMP("\nIncorporated count data had inconsistencies; blending profile...\n");
ProfileSynthesis::Run(this, ProfileSynthesisOption::BlendLikelihoods);
JITDUMP("\nIncorporated count data had inconsistencies; repairing profile...\n");
ProfileSynthesis::Run(this, ProfileSynthesisOption::RepairLikelihoods);
}
}

Expand Down Expand Up @@ -3266,15 +3266,9 @@ class EfficientEdgeCountReconstructor : public SpanningTreeVisitor

// Are there are reparable issues with the reconstruction?
//
// Ideally we'd also have || !m_negativeCount here, but this
// leads to lots of diffs in async methods.
//
// Looks like we might first need to resolve reconstruction
// shortcomings with irreducible loops.
//
bool IsGood() const
{
return !m_entryWeightZero;
return !(m_entryWeightZero || m_negativeCount);
}

void VisitBlock(BasicBlock*) override
Expand Down
Loading