Add Windows Forms TaskDialog API sample#3702
Conversation
e9a7f75 to
0d5b413
Compare
0d5b413 to
e0dff7e
Compare
|
Thanks for adding this here! This sample should be split into two, a csharp one and a vb one. Basically, add a readme in the root directory for each sample, it should contain a metadata header so that the sample shows up in the samples browser. Here is an example of the header: https://raw.githubusercontent.com/dotnet/samples/master/mef/simple-calculator/vb/readme.md Which looks like this: |
adegeo
left a comment
There was a problem hiding this comment.
Changes requested based on the previous comment.
|
Updated, please have a look |
|
Thanks! Which preview of .NET 5 is required? |
|
.NET 5.0 Preview 4
|
adegeo
left a comment
There was a problem hiding this comment.
Final changes and we're good-to-go. Thanks a bunch for helping out!
0634fe3 to
c2fbf6d
Compare
|
done |
c2fbf6d to
c38457d
Compare
|
I'm going to hold off on merging this. I have a PR that enables our CI testing and I need to update it for .NET 5, so this PR is a great test case. Is that OK? Let me know. Thanks! |
|
No worries. No rush on my part. Thank you |
Summary
Add a sample for Windows Forms TaskDialog API, that was added in .NET 5.0 in dotnet/winforms#1133.
Credits: this sample was authored by @kpreisser in https://github.com/kpreisser/TaskDialogDemo, the author of
Task Dialogfor Windows Forms.