Change how commit SHA is obtained#4540
Merged
gewarren merged 1 commit intodotnet:mainfrom Apr 19, 2021
Merged
Conversation
IEvangelist
approved these changes
Apr 19, 2021
Member
IEvangelist
left a comment
IEvangelist
left a comment
There was a problem hiding this comment.
Looks good to me, 
when you're ready.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Getting the last commit from the commits array was not reliable - e.g. see dotnet/docs#23766. This changes how we get the commit SHA, depending on if the action is PR open/reopen or a new commit was pushed.
Reference: https://frontside.com/blog/2020-05-26-github-actions-pull_request/