Skip to content

Migrate GitHub Issues to 1.0.0-preview#840

Merged
JRAlexander merged 4 commits intodotnet:masterfrom
prathyusha12345:migration/1.0.0-Github
Apr 29, 2019
Merged

Migrate GitHub Issues to 1.0.0-preview#840
JRAlexander merged 4 commits intodotnet:masterfrom
prathyusha12345:migration/1.0.0-Github

Conversation

@prathyusha12345
Copy link
Copy Markdown
Contributor

Migrated the project to Ml.Net 1.0.0-preview

Copy link
Copy Markdown
Contributor

@JRAlexander JRAlexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, it appears you are pulling in commits from an earlier PR. Can you check this? Just a few changes.

Comment thread machine-learning/tutorials/GitHubIssueClassification/Program.cs Outdated
Comment thread machine-learning/tutorials/GitHubIssueClassification/Program.cs Outdated
Comment thread machine-learning/tutorials/GitHubIssueClassification/Program.cs Outdated
@prathyusha12345
Copy link
Copy Markdown
Contributor Author

prathyusha12345 commented Apr 24, 2019

@JRAlexander Thanks for identifying. I fixed the spelling. Can you check once

@JRAlexander
Copy link
Copy Markdown
Contributor

Nice work, @prathyusha12345!

@JRAlexander JRAlexander added the 🚧 Hold for related PR Indicates a PR can only be merged when other related PRs are merged (see comments for links) label Apr 26, 2019
@JRAlexander
Copy link
Copy Markdown
Contributor

@cjgronlund - Do you explicitly approve this PR for BUILD ask mode?

@cjgronlund
Copy link
Copy Markdown

Approve.

@JRAlexander JRAlexander added signed-off and removed 🚧 Hold for related PR Indicates a PR can only be merged when other related PRs are merged (see comments for links) labels Apr 29, 2019
@JRAlexander JRAlexander merged commit 257ee91 into dotnet:master Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants