Open
Conversation
This reverts commit 179e5cd.
…dks being installed.
Contributor
Author
mmitche
reviewed
Apr 22, 2024
| [Fact] | ||
| [Trait("Category", "Workload")] | ||
| [Trait("SkipIfPlatform", "LINUX")] | ||
| [Trait("SkipIfPlatform", "OSX")] |
Member
There was a problem hiding this comment.
I think these maui tests should pass on Mac?
Contributor
Author
There was a problem hiding this comment.
They surprisingly don't. They fail due to xCode being missing I believe. It might have been a version problem but I don't have the logs on hand to back that up as it's been a few weeks since I tried.
Contributor
Author
There was a problem hiding this comment.
It is likely a fixable machine problem, but installing xCode isn't probably something we should be doing as part of this execution I think?
Member
There was a problem hiding this comment.
That's sorta surprising...It should be installed by default (it supports the build tooling).
mmitche
approved these changes
Apr 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial PR to test OS compatibility. As this has a mac and android test, I expect things to be weird.