Microsoft.NETFramework.ReferenceAssemblies is not marked as PrivateAssets=All

[andrew-boyarshin]

I've spent some time fine-tuning SharpGen.Runtime dependency graph and there is one unexpected public dependency for 4.7.1.

Design spec mentiones that:

The reference assembly packages should not show up as dependencies of "normal" packages. Thus, the reference assembly packages should set developmentDependency to true in it's metadata. Likewise, when the .NET SDK automatically references the reference assembly metapackage, it should use PrivateAssets="All".

But the implementation in #10981 omitted the last part.

[andrew-boyarshin]

Cross-referencing my SharpGen draft PR.

[andrew-boyarshin]

By the way, AutomaticallyUseReferenceAssemblyPackages doesn't check if it is already set, so I can't override it from Directory.Build.props (it is imported from Microsoft.Common.props, before .NET SDK props).

[andrew-boyarshin]

cc @terrajobst @dsplaisted @sfoslund

[dsplaisted]

Argh, I'm annoyed that I missed this :-)

@sfoslund, I think this should be a quick fix, can you go ahead and fix it?

[sfoslund]

@dsplaisted yup, already on it. PR here: #11491