Single automatic assembly pack package reference#11242
Merged
Merged
Conversation
dsplaisted
requested changes
Apr 11, 2020
Member
dsplaisted
left a comment
dsplaisted
left a comment
There was a problem hiding this comment.
It looks like this doesn't actually prevent the duplicate references, it just inserts the duplicate reference after the check that's supposed to catch them.
sfoslund
force-pushed
the
RefAssemblyPackReference
branch
from
207c56d to
2c3b3f6
Compare
Member
Author
|
@dsplaisted my bad, this should be fixed in the new changes, thanks! |
Member
Author
|
@dsplaisted this is blocking a dependency PR into master, do you mind giving it another look now that I've pushed updates? Thanks! |
dsplaisted
reviewed
Apr 17, 2020
dsplaisted
approved these changes
Apr 17, 2020
Member
dsplaisted
left a comment
dsplaisted
left a comment
There was a problem hiding this comment.
Can you add a test that verifies that everything works and there are no warnings if you have an explicit reference to the package?
Member
Author
|
@dsplaisted this test should verify that already, I added a check for the warning so it fails without this fix now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BeforeTargetsso package reference is only added once in a multitargeted project, instead of once per .NET framework TFM.Should fix warnings we're seeing with #11188