Add modern --blame params to dotnet vstest and dotnet test + dll#12690
Merged
Conversation
This test is testing CSC behavior. It does not test SDK code. The behaivor is also changed due to dotnet/roslyn#42769
ViktorHofer
approved these changes
Jul 29, 2020
nohwnd
added a commit
to nohwnd/sdk
that referenced
this pull request
Jul 29, 2020
…net#12690) * Remove unnecessary test This test is testing CSC behavior. It does not test SDK code. The behaivor is also changed due to dotnet/roslyn#42769 * Add --blame options to dotnet vstest and dotnet test + dll * Uncomment other test cases * Fix comma * Refactor to recude code repetition * Ensure that legacy Blame syntax still works Co-authored-by: William Li <wul@microsoft.com>
ViktorHofer
pushed a commit
that referenced
this pull request
Jul 30, 2020
) (#12699) * Remove unnecessary test This test is testing CSC behavior. It does not test SDK code. The behaivor is also changed due to dotnet/roslyn#42769 * Add --blame options to dotnet vstest and dotnet test + dll * Uncomment other test cases * Fix comma * Refactor to recude code repetition * Ensure that legacy Blame syntax still works Co-authored-by: William Li <wul@microsoft.com> Co-authored-by: William Li <wul@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dotnet vstest and dotnet test + dll are just thin wrappers over vstest.console so we need to translate the params to the way that vstest.console understands in order to be able to use them.