Skip to content

[release/5.0.1xx-preview8] Update dependencies from microsoft/vstest#12716

Merged
dotnet-maestro[bot] merged 1 commit into
release/5.0.1xx-preview8from
darc-release/5.0.1xx-preview8-aabfdf74-5a7f-4816-b06b-2df023dc3406
Jul 30, 2020
Merged

[release/5.0.1xx-preview8] Update dependencies from microsoft/vstest#12716
dotnet-maestro[bot] merged 1 commit into
release/5.0.1xx-preview8from
darc-release/5.0.1xx-preview8-aabfdf74-5a7f-4816-b06b-2df023dc3406

Conversation

@dotnet-maestro
Copy link
Copy Markdown
Contributor

This pull request updates the following dependencies

From https://github.com/microsoft/vstest

  • Subscription: 7ed3ff5b-1270-4370-3cc2-08d824643728
  • Build: 20200730-03
  • Date Produced: 7/30/2020 1:01 PM
  • Commit: ddb755f58160c0e7fab50964d665be1bf47ff579
  • Branch: refs/heads/master
  • Updates:
    • Microsoft.NET.Test.Sdk: from 16.8.0-preview-20200730-02 to 16.8.0-preview-20200730-03

…200730-03

Microsoft.NET.Test.Sdk
 From Version 16.8.0-preview-20200730-02 -> To Version 16.8.0-preview-20200730-03
@dotnet-maestro
Copy link
Copy Markdown
Contributor Author

dotnet-maestro Bot commented Jul 30, 2020

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Waiting on checks: dotnet-sdk-public-ci, dotnet-sdk-public-ci (Build Darwin Build_Release), dotnet-sdk-public-ci (Build Darwin Build_Debug), dotnet-sdk-public-ci (Build Windows_NT Build_Release), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Release), dotnet-sdk-public-ci (Build Ubuntu_16_04 Build_Release), dotnet-sdk-public-ci (Build Windows_NT Build_Debug), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Debug), dotnet-sdk-public-ci (Build Ubuntu_16_04 Build_Debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
  • ✔️ Standard Merge Policies Succeeded - No version downgrade detected.

@Anipik
Copy link
Copy Markdown
Contributor

Anipik commented Jul 30, 2020

@ViktorHofer any particular reason behind the ask mode label ? do we need to bring it to tactics before merging ?

@dotnet-maestro
Copy link
Copy Markdown
Contributor Author

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Waiting on checks: dotnet-sdk-public-ci, dotnet-sdk-public-ci (Build Darwin Build_Release), dotnet-sdk-public-ci (Build Darwin Build_Debug), dotnet-sdk-public-ci (Build Windows_NT Build_Release), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Release), dotnet-sdk-public-ci (Build Ubuntu_16_04 Build_Release), dotnet-sdk-public-ci (Build Windows_NT Build_Debug), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Debug), dotnet-sdk-public-ci (Build Ubuntu_16_04 Build_Debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
  • ✔️ Standard Merge Policies Succeeded - No version downgrade detected.

@ViktorHofer
Copy link
Copy Markdown
Member

It's a tooling change. Don't we need to?

@Anipik
Copy link
Copy Markdown
Contributor

Anipik commented Jul 30, 2020

We don't do this for dependency updates. The original commit that is triggering the dependency updates should be approved by tactics

@dotnet-maestro
Copy link
Copy Markdown
Contributor Author

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Waiting on checks: dotnet-sdk-public-ci, dotnet-sdk-public-ci (Build Darwin Build_Release), dotnet-sdk-public-ci (Build Darwin Build_Debug), dotnet-sdk-public-ci (Build Windows_NT Build_Release), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Release), dotnet-sdk-public-ci (Build Ubuntu_16_04 Build_Release), dotnet-sdk-public-ci (Build Windows_NT Build_Debug), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Debug), dotnet-sdk-public-ci (Build Ubuntu_16_04 Build_Debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
  • ✔️ Standard Merge Policies Succeeded - No version downgrade detected.

@ViktorHofer
Copy link
Copy Markdown
Member

We don't do this for dependency updates. The original commit that is triggering the dependency updates should be approved by tactics

That's news to me. I have never heard of Tactics approving commits in Microsoft/vstest. VSTest currently flow bits from their master branch which means that Tactics would need to approve any master commit.

@dotnet-maestro
Copy link
Copy Markdown
Contributor Author

dotnet-maestro Bot commented Jul 30, 2020

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Waiting on checks: dotnet-sdk-public-ci, dotnet-sdk-public-ci (Build Darwin Build_Release), dotnet-sdk-public-ci (Build Darwin Build_Debug), dotnet-sdk-public-ci (Build Windows_NT Build_Release), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Release), dotnet-sdk-public-ci (Build Ubuntu_16_04 Build_Release), dotnet-sdk-public-ci (Build Windows_NT Build_Debug), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Debug), dotnet-sdk-public-ci (Build Ubuntu_16_04 Build_Debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
  • ✔️ Standard Merge Policies Succeeded - No version downgrade detected.

1 similar comment
@dotnet-maestro
Copy link
Copy Markdown
Contributor Author

dotnet-maestro Bot commented Jul 30, 2020

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Waiting on checks: dotnet-sdk-public-ci, dotnet-sdk-public-ci (Build Darwin Build_Release), dotnet-sdk-public-ci (Build Darwin Build_Debug), dotnet-sdk-public-ci (Build Windows_NT Build_Release), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Release), dotnet-sdk-public-ci (Build Ubuntu_16_04 Build_Release), dotnet-sdk-public-ci (Build Windows_NT Build_Debug), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Debug), dotnet-sdk-public-ci (Build Ubuntu_16_04 Build_Debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
  • ✔️ Standard Merge Policies Succeeded - No version downgrade detected.

@Anipik
Copy link
Copy Markdown
Contributor

Anipik commented Jul 30, 2020

That's news to me. I have never heard of Tactics approving commits in Microsoft/vstest. VSTest currently flow bits from their master branch which means that Tactics would need to approve any master commit.

I think u r right here. I think We dont generally seek approval for dependency updates from VSTest, because they are version updates with no real commit sha changes.

@dotnet-maestro
Copy link
Copy Markdown
Contributor Author

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Waiting on checks: dotnet-sdk-public-ci, dotnet-sdk-public-ci (Build Darwin Build_Release), dotnet-sdk-public-ci (Build Darwin Build_Debug), dotnet-sdk-public-ci (Build Windows_NT Build_Release), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Release), dotnet-sdk-public-ci (Build Windows_NT Build_Debug), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
  • ✔️ Standard Merge Policies Succeeded - No version downgrade detected.

@ViktorHofer
Copy link
Copy Markdown
Member

because they are version updates with no real commit sha changes.

Unsure what you mean by "no real commit sha changes". Microsoft/vstest is very much alive, we have a team that is actively working on features in the repository.

@dotnet-maestro
Copy link
Copy Markdown
Contributor Author

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Waiting on checks: dotnet-sdk-public-ci, dotnet-sdk-public-ci (Build Darwin Build_Release), dotnet-sdk-public-ci (Build Darwin Build_Debug), dotnet-sdk-public-ci (Build Windows_NT Build_Release), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Release), dotnet-sdk-public-ci (Build Windows_NT Build_Debug), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
  • ✔️ Standard Merge Policies Succeeded - No version downgrade detected.

@Anipik
Copy link
Copy Markdown
Contributor

Anipik commented Jul 30, 2020

Unsure what you mean by "no real commit sha changes".

We are already consuming the latest commit here #12711
Not sure if this pr was created bcoz they push a daily new package.

@ViktorHofer
Copy link
Copy Markdown
Member

ViktorHofer commented Jul 30, 2020

We are already consuming the latest commit here #12711

This isn't the same change, it's missing the macOS env var hang dump support. @nohwnd isn't flowing VSTest master into P8
without any approval super risky? Should we change that?

@dotnet-maestro
Copy link
Copy Markdown
Contributor Author

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Waiting on checks: dotnet-sdk-public-ci, dotnet-sdk-public-ci (Build Darwin Build_Release), dotnet-sdk-public-ci (Build Darwin Build_Debug), dotnet-sdk-public-ci (Build Windows_NT Build_Release), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Release), dotnet-sdk-public-ci (Build Windows_NT Build_Debug), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
  • ✔️ Standard Merge Policies Succeeded - No version downgrade detected.

@Anipik
Copy link
Copy Markdown
Contributor

Anipik commented Jul 30, 2020

@nohwnd isn't merging all master commits into P8 super risky? Should we change that?

did u mean master and P8 of the sdk repo ?

@dotnet-maestro
Copy link
Copy Markdown
Contributor Author

dotnet-maestro Bot commented Jul 30, 2020

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Waiting on checks: dotnet-sdk-public-ci, dotnet-sdk-public-ci (Build Darwin Build_Release), dotnet-sdk-public-ci (Build Darwin Build_Debug), dotnet-sdk-public-ci (Build Windows_NT Build_Release), dotnet-sdk-public-ci (Build Windows_NT Build_Debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
  • ✔️ Standard Merge Policies Succeeded - No version downgrade detected.

@nohwnd
Copy link
Copy Markdown
Member

nohwnd commented Jul 30, 2020

@ViktorHofer disabled, we now push from master only to VS Master channel, which would end up in as a PR against dotnet/sdk master.

If there are more updates needed for P8 we will need to do that via rel/16.8 branch in vstest.

@dotnet-maestro
Copy link
Copy Markdown
Contributor Author

dotnet-maestro Bot commented Jul 30, 2020

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: dotnet-sdk-public-ci, dotnet-sdk-public-ci (Build Darwin Build_Release)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
  • ✔️ Standard Merge Policies Succeeded - No version downgrade detected.

@ViktorHofer
Copy link
Copy Markdown
Member

/azp run dotnet-sdk-public-ci

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@dotnet-maestro
Copy link
Copy Markdown
Contributor Author

dotnet-maestro Bot commented Jul 30, 2020

Auto-Merge Status

This pull request has been merged because the following merge policies have succeeded.

  • ✔️ Standard Merge Policies Succeeded - Successful checks: dotnet-sdk-public-ci, dotnet-sdk-public-ci (Build Windows_NT_TestAsTools Build_Debug), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Release), dotnet-sdk-public-ci (Build Windows_NT Build_Release), dotnet-sdk-public-ci (Build Ubuntu_16_04 Build_Release), dotnet-sdk-public-ci (Build Darwin Build_Release), dotnet-sdk-public-ci (Build Windows_NT Build_Debug), dotnet-sdk-public-ci (Build Ubuntu_16_04 Build_Debug), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Debug), dotnet-sdk-public-ci (Build Darwin Build_Debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
  • ✔️ Standard Merge Policies Succeeded - No version downgrade detected.

@dotnet-maestro dotnet-maestro Bot merged commit 89d3f30 into release/5.0.1xx-preview8 Jul 30, 2020
@dotnet-maestro dotnet-maestro Bot deleted the darc-release/5.0.1xx-preview8-aabfdf74-5a7f-4816-b06b-2df023dc3406 branch July 30, 2020 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants