[release/5.0.1xx-preview8] Update dependencies from microsoft/vstest#12716
Conversation
…200730-03 Microsoft.NET.Test.Sdk From Version 16.8.0-preview-20200730-02 -> To Version 16.8.0-preview-20200730-03
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
|
@ViktorHofer any particular reason behind the ask mode label ? do we need to bring it to tactics before merging ? |
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
|
It's a tooling change. Don't we need to? |
|
We don't do this for dependency updates. The original commit that is triggering the dependency updates should be approved by tactics |
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
That's news to me. I have never heard of Tactics approving commits in Microsoft/vstest. VSTest currently flow bits from their master branch which means that Tactics would need to approve any master commit. |
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
1 similar comment
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
I think u r right here. I think We dont generally seek approval for dependency updates from VSTest, because they are version updates with no real commit sha changes. |
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
Unsure what you mean by "no real commit sha changes". Microsoft/vstest is very much alive, we have a team that is actively working on features in the repository. |
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
We are already consuming the latest commit here #12711 |
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
did u mean master and P8 of the sdk repo ? |
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
|
@ViktorHofer disabled, we now push from master only to VS Master channel, which would end up in as a PR against dotnet/sdk master. If there are more updates needed for P8 we will need to do that via rel/16.8 branch in vstest. |
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
|
/azp run dotnet-sdk-public-ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Auto-Merge StatusThis pull request has been merged because the following merge policies have succeeded.
|
This pull request updates the following dependencies
From https://github.com/microsoft/vstest