Skip to content

Rename SdkSupportedTargetPlatform, add SupportedTargetPlatform#12872

Merged
sfoslund merged 5 commits into
dotnet:masterfrom
sfoslund:SupportedTargetPlatform
Aug 24, 2020
Merged

Rename SdkSupportedTargetPlatform, add SupportedTargetPlatform#12872
sfoslund merged 5 commits into
dotnet:masterfrom
sfoslund:SupportedTargetPlatform

Conversation

@sfoslund
Copy link
Copy Markdown
Member

@sfoslund sfoslund commented Aug 11, 2020 •
edited
Loading

Fixes #12706

cc @terrajobst

sfoslund
sfoslund commented Aug 11, 2020
View reviewed changes
Comment thread src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.SupportedTargetPlatforms.props Outdated
pranavkm
pranavkm reviewed Aug 13, 2020
View reviewed changes
Comment thread src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.SupportedTargetPlatforms.props Outdated
terrajobst
terrajobst reviewed Aug 14, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@terrajobst terrajobst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should name the group SupportedPlatform but other than that, it looks good.

Comment thread src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.SupportedTargetPlatforms.props Outdated
@terrajobst
Copy link
Copy Markdown
Contributor

terrajobst commented Aug 14, 2020

I've talked @pranavkm, he'll make sure the Blazor SDK will do this in their .props file:

<ItemGroup>
    <SupportedPlatform Remove="@(SupportedPlatform)" />
    <SupportedPlatform Include="browser" />
</ItemGroup>

For more details, see the spec.

@terrajobst terrajobst mentioned this pull request Aug 14, 2020
Closed
@terrajobst
Copy link
Copy Markdown
Contributor

terrajobst commented Aug 17, 2020 •
edited
Loading

@sfoslund @dsplaisted will this be merged before 3?

pranavkm added a commit to dotnet/aspnetcore that referenced this pull request Aug 17, 2020
@pranavkm
Enable the compatibility analyzer for Blazor WebAssembly
f269454 
See dotnet/sdk#12872 (comment)
@pranavkm pranavkm mentioned this pull request Aug 17, 2020
Merged
@terrajobst
Copy link
Copy Markdown
Contributor

terrajobst commented Aug 17, 2020 •
edited
Loading

@sfoslund @dsplaisted will this be merged before 3?

Let's not do a fire drill this week. But we should get it in soon-ish.

@pranavkm
Fix typo in name
1a22b5c 
Experimenting to see what happens if I edit a different repo
pranavkm
pranavkm reviewed Aug 19, 2020
View reviewed changes
Comment thread src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.SupportedTargetPlatforms.props Outdated
Comment thread src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.SupportedTargetPlatforms.props Outdated
Comment thread src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.SupportedTargetPlatforms.props Outdated
Comment thread src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.SupportedTargetPlatforms.props Outdated
Comment thread src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.SupportedTargetPlatforms.props Outdated
pranavkm
pranavkm approved these changes Aug 19, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@pranavkm pranavkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dsplaisted would you mind reviewing this?

pranavkm added a commit to dotnet/aspnetcore that referenced this pull request Aug 19, 2020
@pranavkm
Enable the compatibility analyzer for Blazor WebAssembly (#24978)
c6814f4 
See dotnet/sdk#12872 (comment)
@wli3
Copy link
Copy Markdown

wli3 commented Aug 19, 2020

Need to adjust against #12775

dsplaisted
dsplaisted reviewed Aug 20, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@dsplaisted dsplaisted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm not sure what @wli3 means by this:

Need to adjust against #12775

So I'd make sure to clarify that first

Comment thread src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.SupportedTargetPlatforms.props
Comment thread src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.SupportedTargetPlatforms.props Outdated
Comment thread ...sks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.WindowsSdkSupportedTargetPlatforms.props
@sfoslund
Copy link
Copy Markdown
Member Author

sfoslund commented Aug 20, 2020

will this be merged before 3?

@terrajobst sorry, I was OOF at the beginning of this week. I'll update based on feedback now and get this in this week.

@jeffhandley
Copy link
Copy Markdown
Member

jeffhandley commented Aug 20, 2020

I think @pranavkm mentioned he was going to take a look at this too--but I'm not sure if he took any actions on it yet.

@pranavkm
Copy link
Copy Markdown
Contributor

pranavkm commented Aug 20, 2020

I edited some of these files, but looks like @sfoslund's got a handle on this 👍

@sfoslund
Copy link
Copy Markdown
Member Author

sfoslund commented Aug 20, 2020

@dsplaisted @terrajobst does this look okay to you?

@dsplaisted
Copy link
Copy Markdown
Member

dsplaisted commented Aug 20, 2020

@dsplaisted @terrajobst does this look okay to you?

Yes, but I'd like clarification from @wli3 on what he meant in this comment

@wli3
Copy link
Copy Markdown

wli3 commented Aug 20, 2020

Now I look it in detail. This change has nothing to do with the attribute "SupportedOSPlatformAttribute" in #12775 right? And this rename is to avoid that name conflict. If so, this is good.

@terrajobst
Copy link
Copy Markdown
Contributor

terrajobst commented Aug 20, 2020

Now I look it in detail. This change has nothing to do with the attribute "SupportedOSPlatformAttribute" in #12775 right? And this rename is to avoid that name conflict. If so, this is good

Logically related, but independent. This item group is only used by our analyzer.

@mavasani what is required to pass this down? Do we need to register the item group somewhere? Or did you do that already?

@mavasani
Copy link
Copy Markdown
Contributor

mavasani commented Aug 21, 2020

I presume you mean: dotnet/roslyn-analyzers#3950 (comment)?

@sfoslund
Copy link
Copy Markdown
Member Author

sfoslund commented Aug 24, 2020

@mavasani things are good on your side for this to go in then?

@mavasani
Copy link
Copy Markdown
Contributor

mavasani commented Aug 24, 2020

@mavasani things are good on your side for this to go in then?

I am not sure I understand the changes in this PR, but updating the analyzers to understand any name chosen here would be a trivial change, so in that sense this PR does not break or hinder the analyzers in anyway.

@sfoslund
Copy link
Copy Markdown
Member Author

sfoslund commented Aug 24, 2020

Great, sounds like this is good to go in then. I'll merge it today unless there are any objections.

@sfoslund sfoslund merged commit 5615589 into dotnet:master Aug 24, 2020
@sfoslund sfoslund deleted the SupportedTargetPlatform branch August 24, 2020 21:49
@sfoslund sfoslund mentioned this pull request Aug 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dsplaisted dsplaisted dsplaisted left review comments

+2 more reviewers

@terrajobst terrajobst terrajobst left review comments

@pranavkm pranavkm pranavkm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Provide a standard item group for OS platforms

7 participants

@sfoslund @terrajobst @wli3 @jeffhandley @pranavkm @dsplaisted @mavasani