Refactor SDK Resolver into separate library, add simple workload manifest reader#12884
Merged
wli3 merged 3 commits intodotnet:masterfrom Aug 17, 2020
Merged
Refactor SDK Resolver into separate library, add simple workload manifest reader#12884wli3 merged 3 commits intodotnet:masterfrom
wli3 merged 3 commits intodotnet:masterfrom
Conversation
wli3
approved these changes
Aug 12, 2020
wli3
reviewed
Aug 12, 2020
| { | ||
| class WorkloadManifest | ||
| { | ||
| public Dictionary<string, List<string>> Workloads { get; set; } = new Dictionary<string, List<string>>(StringComparer.OrdinalIgnoreCase); |
There was a problem hiding this comment.
The interface is the same as the real thing or a place holder too?
Member
Author
There was a problem hiding this comment.
I'm sure the API will change.
|
And for template pack, it will just have the pack "kind" be "template" right? |
Member
Author
I think so. The API doesn't currently represent the pack "kind". |
dsplaisted
force-pushed
the
xml-workload-manifest
branch
from
37637fc to
a948332
Compare
|
I'll just change the manifest reader in my PR later. Since the API shape is not final |
|
Test failed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the following two projects:
The workload manifest format is super simple, to be replaced eventually by what is specified in dotnet/designs#120.
Example of workload manifest: