Enable content copying transitive in VS.#14256
Closed
ocallesp wants to merge 1 commit intodotnet:masterfrom
ocallesp:fix/issue/4923_MSBuildCopyContentTransitively
Closed
Enable content copying transitive in VS.#14256ocallesp wants to merge 1 commit intodotnet:masterfrom ocallesp:fix/issue/4923_MSBuildCopyContentTransitively
ocallesp wants to merge 1 commit intodotnet:masterfrom
ocallesp:fix/issue/4923_MSBuildCopyContentTransitively
Conversation
This is needed to fix the Fast up-to-date to check CopyToOutputDirectory items from project references dotnet/project-system#4665 More details on MSBuildCopyContentTransitively in dotnet/msbuild#4865
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem:
Currently Fast-up-date (FUTD) cannot resolve
CopyToOutputDirectorytransitively.Lets assume there is project A and has a reference to B and B has a reference to C.
If C contains items with
CopyToOutputDirectory, and if those items are modified, then project A will not detect those changes.Bug dotnet/project-system#4665
The fix for the issue 4665 is in the pr 6046 in dotnet ProjectSystem, but this changes will cause conflicts with dependencies of
_SplitProjectReferencesByFileExistence. This pr 6046 in dotnet ProjectSystem executes targets that has dependencies withAssignProjectConfiguration. The problem is that dotnet will consume the output generated by those dependencies beforeAssignProjectConfigurationis executed. This causesAssignProjectConfigurationto consume no data. More details in here.What this change does:
Set MSBuildCopyContentTransitively to true which means transitive copying content.
How this change help to solve the dependencies:
MSBuildCopyContentTransitively= true means transitive copying content. ProjectSystem andAssignProjectConfigurationwill have their own copy of the content.This change is not high priority.