Implement Text-Based Performance Log#14409
Merged
brianrob merged 2 commits intodotnet:release/5.0.2xxfrom Nov 3, 2020
Merged
Conversation
|
@sfoslund @dsplaisted @joeloff FYI, I reviewed most of the PR in a fork wli3#1 already |
wli3
approved these changes
Nov 3, 2020
Member
Author
|
Confirmed that |
|
@brianrob good to merge |
Member
Author
|
Thanks @wli3! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements a text-based performance log scheme that writes coarse-grained performance logs:
DOTNET_CLI_PERF_LOG=1.<DotnetUserProfilePath>\PerformanceLogs. Logs for an individual invocation of the CLI can be redirected viaDOTNET_PERFLOG_DIR.DOTNET_PERF_LOG_COUNT. Set this variable to-1to keep all logs.PerformanceLogEventSourceso that the events can be consumed through other profilers, such as those that use ETW.DOTNET_PERFLOG_DIRwhen spawning msbuild processes so that msbuild can contribute to the performance log.cc: @marcpopMSFT, @davidfowl, @DamianEdwards, @bwadswor