Skip to content

[master] Update dependencies from mono/linker#14925

Merged
dotnet-maestro[bot] merged 11 commits into
masterfrom
darc-master-70b7463d-b779-49b9-a848-870b9f513d5c
Dec 15, 2020
Merged

[master] Update dependencies from mono/linker#14925
dotnet-maestro[bot] merged 11 commits into
masterfrom
darc-master-70b7463d-b779-49b9-a848-870b9f513d5c

Conversation

@dotnet-maestro
Copy link
Copy Markdown
Contributor

@dotnet-maestro dotnet-maestro Bot commented Dec 10, 2020

This pull request updates the following dependencies

From https://github.com/mono/linker

  • Subscription: 9ac01057-d33d-4509-c9e1-08d846b6e5b9
  • Build: 20201215.1
  • Date Produced: 12/15/2020 9:44 AM
  • Commit: a074fbfd1d0d639893bd61afc7e946a275af9e55
  • Branch: refs/heads/master

Microsoft.NET.ILLink.Tasks
 From Version 6.0.0-alpha.1.20608.3 -> To Version 6.0.0-alpha.1.20610.1
Microsoft.NET.ILLink.Tasks
 From Version 6.0.0-alpha.1.20608.3 -> To Version 6.0.0-alpha.1.20611.1
Microsoft.NET.ILLink.Tasks
 From Version 6.0.0-alpha.1.20608.3 -> To Version 6.0.0-alpha.1.20611.2
@marek-safar
Copy link
Copy Markdown
Contributor

@sbomer this PR is blocked because of the XML descriptor breaking change. The failing test is Microsoft.NET.Publish.Tests.GivenThatWeWantToRunILLink.ILLink_respects_feature_settings_from_host_config. Maybe we should change the warning to be an error.

resource ILLink.Substitutions.xml in HelloWorld, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null : warning IL2101: Embedded XML in assembly 'HelloWorld' contains assembly "fullname" attribute for another assembly 'ClassLibForILLink, Version=0.0.0.0, Culture=neutral, PublicKeyToken=null' [C:\h\w\B6C709AD\t\dotnetSdkTests\zfbva2hp.w0h\ILLink_respec---D9B75401\HelloWorld\HelloWorld.csproj]

Then there is second problem which looks like is caused by the automatic removal of default ctors for serializable types.

Fatal error. Internal CLR error. (0x80131506)
   at System.RuntimeTypeHandle.CreateInstanceForAnotherGenericParameter(System.RuntimeType, System.RuntimeType)
   at System.Collections.Generic.ComparerHelpers.CreateDefaultEqualityComparer(System.Type)
   at System.Collections.Generic.EqualityComparer`1[[System.__Canon, System.Private.CoreLib, Version=5.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]]..cctor()
   at System.Collections.Generic.EqualityComparer`1[[System.__Canon, System.Private.CoreLib, Version=5.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].get_Default()
   at System.Collections.Generic.NonRandomizedStringEqualityComparer..cctor()
   at System.Collections.Generic.Dictionary`2[[System.__Canon, System.Private.CoreLib, Version=5.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.__Canon, System.Private.CoreLib, Version=5.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]]..ctor(Int32, System.Collections.Generic.IEqualityComparer`1<System.__Canon>)
   at System.AppContext.Setup(Char**, Char**, Int32)

@vitek-karas This shows up in runtime update as well dotnet/runtime#45926 and it looks like we are missing annotations somewhere.

@marek-safar
Copy link
Copy Markdown
Contributor

Fixed the second problem by reverting the change

Microsoft.NET.ILLink.Tasks
 From Version 6.0.0-alpha.1.20608.3 -> To Version 6.0.0-alpha.1.20611.3
sbomer added a commit to sbomer/sdk that referenced this pull request Dec 11, 2020
Avoids modifying other assemblies in embedded XML, in response to
dotnet/linker#1675.

This will unblock dependency flow in dotnet#14925.
sbomer added a commit to sbomer/sdk that referenced this pull request Dec 11, 2020
Avoids modifying other assemblies in embedded XML, in response to
dotnet/linker#1675.

This will unblock dependency flow in dotnet#14925.
@sbomer sbomer mentioned this pull request Dec 11, 2020
Microsoft.NET.ILLink.Tasks
 From Version 6.0.0-alpha.1.20608.3 -> To Version 6.0.0-alpha.1.20611.4
Microsoft.NET.ILLink.Tasks
 From Version 6.0.0-alpha.1.20608.3 -> To Version 6.0.0-alpha.1.20614.1
Microsoft.NET.ILLink.Tasks
 From Version 6.0.0-alpha.1.20608.3 -> To Version 6.0.0-alpha.1.20614.2
Microsoft.NET.ILLink.Tasks
 From Version 6.0.0-alpha.1.20608.3 -> To Version 6.0.0-alpha.1.20614.3
Microsoft.NET.ILLink.Tasks
 From Version 6.0.0-alpha.1.20608.3 -> To Version 6.0.0-alpha.1.20614.4
sbomer added a commit that referenced this pull request Dec 14, 2020
* Fix illink test

Avoids modifying other assemblies in embedded XML, in response to
dotnet/linker#1675.

This will unblock dependency flow in #14925.

* Avoid deconstructing KeyValuePair

Not implemented in .NET Framework
Microsoft.NET.ILLink.Tasks
 From Version 6.0.0-alpha.1.20608.3 -> To Version 6.0.0-alpha.1.20614.5
Microsoft.NET.ILLink.Tasks
 From Version 6.0.0-alpha.1.20608.3 -> To Version 6.0.0-alpha.1.20615.1
@dotnet-maestro dotnet-maestro Bot merged commit 629e828 into master Dec 15, 2020
@dotnet-maestro dotnet-maestro Bot deleted the darc-master-70b7463d-b779-49b9-a848-870b9f513d5c branch December 15, 2020 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant