[preview4] Make TrimmerDefaultAction public#17019
Merged
sbomer merged 3 commits intodotnet:release/6.0.1xx-preview4from Apr 20, 2021
Merged
[preview4] Make TrimmerDefaultAction public#17019sbomer merged 3 commits intodotnet:release/6.0.1xx-preview4from
sbomer merged 3 commits intodotnet:release/6.0.1xx-preview4from
Conversation
Fixes dotnet#16140 Relevant for dotnet/docs#23766
So that the condition takes into account properties set in the project file.
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
agocke
approved these changes
Apr 20, 2021
| <AddRazorSupportForMvc Condition="'$(DisableImplicitFrameworkReferences)' != 'true' And '$(AddRazorSupportForMvc)' == '' And '$(TargetFrameworkIdentifier)' == '.NETCoreApp' And '$(_TargetFrameworkVersionWithoutV)' >= '3.0'">true</AddRazorSupportForMvc> | ||
|
|
||
| <!-- Trimmer defaults that depend on user-definable settings --> | ||
| <SuppressTrimAnalysisWarnings Condition="'$(SuppressTrimAnalysisWarnings)' == '' And '$(TrimmerDefaultAction)' != 'link'">true</SuppressTrimAnalysisWarnings> |
Member
There was a problem hiding this comment.
So ASP.NET has warnings suppressed, but no top-level warning about trimmability? Hmm. We should think about this for .NET 6.
vitek-karas
approved these changes
Apr 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Porting #16865 to preview4 (it just missed the snap and we would like it for the trimming library experience in P4).